Title: [114175] trunk
- Revision
- 114175
- Author
- simon.fra...@apple.com
- Date
- 2012-04-13 15:26:47 -0700 (Fri, 13 Apr 2012)
Log Message
Compositing layers not updated after scroll in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=83945
Source/WebCore:
Reviewed by James Robinson.
Fix the WebKit1 code path to correctly update compositing layers
after a scroll, by calling updateFixedElementsAfterScrolling() from
scrollPositionChangedViaPlatformWidget().
Covered by existing tests.
* page/FrameView.cpp:
(WebCore::FrameView::scrollPositionChangedViaPlatformWidget):
LayoutTests:
Reviewed by James Robinson.
Replace an incorrect Mac baseline with the correct result which was
already in place for WebKit2.
Remove a passing test from test-expectations.
* compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
* platform/mac-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Removed.
* platform/mac/test_expectations.txt:
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (114174 => 114175)
--- trunk/LayoutTests/ChangeLog 2012-04-13 22:09:06 UTC (rev 114174)
+++ trunk/LayoutTests/ChangeLog 2012-04-13 22:26:47 UTC (rev 114175)
@@ -1,3 +1,19 @@
+2012-04-13 Simon Fraser <simon.fra...@apple.com>
+
+ Compositing layers not updated after scroll in WebKit1
+ https://bugs.webkit.org/show_bug.cgi?id=83945
+
+ Reviewed by James Robinson.
+
+ Replace an incorrect Mac baseline with the correct result which was
+ already in place for WebKit2.
+
+ Remove a passing test from test-expectations.
+
+ * compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
+ * platform/mac-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Removed.
+ * platform/mac/test_expectations.txt:
+
2012-04-13 Vincent Scheib <sch...@chromium.org>
Chromium test_expectations suppress platform/chromium/virtual/gpu/fast/canvas/2d.imageDataHD.html
Modified: trunk/LayoutTests/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt (114174 => 114175)
--- trunk/LayoutTests/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt 2012-04-13 22:09:06 UTC (rev 114174)
+++ trunk/LayoutTests/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt 2012-04-13 22:26:47 UTC (rev 114175)
@@ -15,7 +15,7 @@
(drawsContent 1)
)
(GraphicsLayer
- (position 0.00 13.00)
+ (position 0.00 113.00)
(bounds 150.00 142.00)
(drawsContent 1)
)
Modified: trunk/LayoutTests/platform/mac/test_expectations.txt (114174 => 114175)
--- trunk/LayoutTests/platform/mac/test_expectations.txt 2012-04-13 22:09:06 UTC (rev 114174)
+++ trunk/LayoutTests/platform/mac/test_expectations.txt 2012-04-13 22:26:47 UTC (rev 114175)
@@ -183,7 +183,6 @@
BUGWK75568 : fast/replaced/replaced-breaking.html = TEXT
BUGWK75568 : fast/replaced/width100percent-searchfield.html = TEXT
BUGWK75568 : fast/text/textIteratorNilRenderer.html = TEXT
-BUGWK75568 : compositing/geometry/object-clip-rects-assertion.html = TEXT
BUGWK75568 : compositing/overflow/ancestor-overflow.html = TEXT
BUGWK75568 : editing/inserting/before-after-input-element.html = TEXT
BUGWK75568 : editing/pasteboard/4806874.html = TEXT
Deleted: trunk/LayoutTests/platform/mac-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt (114174 => 114175)
--- trunk/LayoutTests/platform/mac-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt 2012-04-13 22:09:06 UTC (rev 114174)
+++ trunk/LayoutTests/platform/mac-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt 2012-04-13 22:26:47 UTC (rev 114175)
@@ -1,26 +0,0 @@
-Text here
-(GraphicsLayer
- (bounds 785.00 1021.00)
- (children 1
- (GraphicsLayer
- (bounds 785.00 1021.00)
- (children 3
- (GraphicsLayer
- (position 29.00 134.00)
- (bounds 100.00 100.00)
- )
- (GraphicsLayer
- (position 29.00 134.00)
- (bounds 100.00 100.00)
- (drawsContent 1)
- )
- (GraphicsLayer
- (position 0.00 113.00)
- (bounds 150.00 142.00)
- (drawsContent 1)
- )
- )
- )
- )
-)
-
Modified: trunk/Source/WebCore/ChangeLog (114174 => 114175)
--- trunk/Source/WebCore/ChangeLog 2012-04-13 22:09:06 UTC (rev 114174)
+++ trunk/Source/WebCore/ChangeLog 2012-04-13 22:26:47 UTC (rev 114175)
@@ -1,3 +1,19 @@
+2012-04-13 Simon Fraser <simon.fra...@apple.com>
+
+ Compositing layers not updated after scroll in WebKit1
+ https://bugs.webkit.org/show_bug.cgi?id=83945
+
+ Reviewed by James Robinson.
+
+ Fix the WebKit1 code path to correctly update compositing layers
+ after a scroll, by calling updateFixedElementsAfterScrolling() from
+ scrollPositionChangedViaPlatformWidget().
+
+ Covered by existing tests.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::scrollPositionChangedViaPlatformWidget):
+
2012-04-13 Dean Jackson <d...@apple.com>
Don't process filters if the input region is exceptionally large.
Modified: trunk/Source/WebCore/page/FrameView.cpp (114174 => 114175)
--- trunk/Source/WebCore/page/FrameView.cpp 2012-04-13 22:09:06 UTC (rev 114174)
+++ trunk/Source/WebCore/page/FrameView.cpp 2012-04-13 22:26:47 UTC (rev 114175)
@@ -1718,6 +1718,7 @@
void FrameView::scrollPositionChangedViaPlatformWidget()
{
repaintFixedElementsAfterScrolling();
+ updateFixedElementsAfterScrolling();
scrollPositionChanged();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
