Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2f05f731f91c81311380119b3e201fb54e48372e
https://github.com/WebKit/WebKit/commit/2f05f731f91c81311380119b3e201fb54e48372e
Author: Youenn Fablet <[email protected]>
Date: 2026-02-17 (Tue, 17 Feb 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-expected.txt
M Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
M Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
Log Message:
-----------
RTCPeerConnection.addIceCandidate should reject when connection is closed
rdar://170470988
https://bugs.webkit.org/show_bug.cgi?id=307980
Reviewed by Brandon Stewart.
As per spec, we need to reject the promise with InvalidStateError in case of
adding an ice candidate to a peer connection.
We just have to remove the early return check since chainOperation handles
already this case.
We also add an early return if peer connection is closed to not send a
candidate event, as per spec, as this can cause some flakinesses in
imported/w3c/web-platform-tests/webrtc/rtp-stats-lifetime.https.html.
*
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-expected.txt:
* Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::iceGatheringStateChanged):
* Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::addIceCandidate):
Canonical link: https://commits.webkit.org/307702@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
