Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3b69954dcfeadf1893a46da52403e4734dae8917
https://github.com/WebKit/WebKit/commit/3b69954dcfeadf1893a46da52403e4734dae8917
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2026-02-18 (Wed, 18 Feb 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm
Log Message:
-----------
REGRESSION(305691@main): [Tahoe]
TestWebKitAPI.UnifiedPDF.SnapshotsPaintPageContent is flaky failure
https://bugs.webkit.org/show_bug.cgi?id=307607
rdar://170186477
Reviewed by Tim Horton.
TestWebKitAPI.UnifiedPDF.SnapshotsPaintPageContent always ran the risk
of producing misleading results. If the plugin contents did not load in
time, the web view snapshot would contain plugin background layer
pixels.
Prior to 305691@main, these coincidentally happened to be non-white, and
thus always "passed" the test assertion. This is no longer the case
since CSSValueAppleSystemBackground defaults to white when the system is
in light mode. Note that this also explains why the regression was
limited to macOS Tahoe, since the background color change was limited to
platforms where ENABLE_LIQUID_GLASS is true.
In this patch, we poll for the expected condition (non-white pixel in
the snapshot) rather than using a fixed delay. This approach is robust
on slower bots while remaining fast in the common case, and converts
actual failures into timeouts.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
(TestWebKitAPI::UNIFIED_PDF_TEST):
Canonical link: https://commits.webkit.org/307748@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
