Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6bc3744f51476655f279015bed5d793b965d1e7c
https://github.com/WebKit/WebKit/commit/6bc3744f51476655f279015bed5d793b965d1e7c
Author: Taher Ali <[email protected]>
Date: 2026-02-18 (Wed, 18 Feb 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-values-trailing-semicolon-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-values-trailing-semicolon.html
M Source/WebCore/svg/SVGAnimationElement.cpp
Log Message:
-----------
SMIL animation: Filter empty values from trailing semicolons in values
attribute
https://bugs.webkit.org/show_bug.cgi?id=308160
rdar://170668176
Reviewed by Brent Fulgham.
The SMIL values attribute parser was including empty strings when a trailing
semicolon was present. This caused setToAtEndOfDurationValue() to fail
validation since the last value was empty.
The WPT test spaces-at-end-of-path-data.html was passing only because
the test checks `assert_not_equals(getComputedStyle(path).d, "none")` which
passed since undefined !== "none".
The broken animation and test was exposed when when investigating CSS d
path here: https://github.com/WebKit/WebKit/pull/58880
*
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-values-trailing-semicolon-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-values-trailing-semicolon.html:
Added.
* Source/WebCore/svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::attributeChanged):
(WebCore::SVGAnimationElement::updateAnimation):
Canonical link: https://commits.webkit.org/307807@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
