Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 71ccea8bd3ab06c8a04fd573b65225e733071983
https://github.com/WebKit/WebKit/commit/71ccea8bd3ab06c8a04fd573b65225e733071983
Author: Qianlang Chen <[email protected]>
Date: 2026-02-19 (Thu, 19 Feb 2026)
Changed paths:
M Source/WebKit/Sources.txt
A Source/WebKit/UIProcess/Inspector/FrameInspectorTargetProxy.cpp
A Source/WebKit/UIProcess/Inspector/FrameInspectorTargetProxy.h
M Source/WebKit/UIProcess/Inspector/InspectorTargetProxy.cpp
A Source/WebKit/UIProcess/Inspector/PageInspectorTargetProxy.cpp
A Source/WebKit/UIProcess/Inspector/PageInspectorTargetProxy.h
R Source/WebKit/UIProcess/Inspector/WebFrameInspectorTargetProxy.cpp
R Source/WebKit/UIProcess/Inspector/WebFrameInspectorTargetProxy.h
M Source/WebKit/UIProcess/Inspector/WebPageInspectorController.cpp
R Source/WebKit/UIProcess/Inspector/WebPageInspectorTargetProxy.cpp
R Source/WebKit/UIProcess/Inspector/WebPageInspectorTargetProxy.h
M Source/WebKit/UIProcess/WebFrameProxy.cpp
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
A Source/WebKit/WebProcess/Inspector/FrameInspectorTarget.cpp
A Source/WebKit/WebProcess/Inspector/FrameInspectorTarget.h
A Source/WebKit/WebProcess/Inspector/PageInspectorTarget.cpp
A Source/WebKit/WebProcess/Inspector/PageInspectorTarget.h
A Source/WebKit/WebProcess/Inspector/UIProcessForwardingFrontendChannel.cpp
A Source/WebKit/WebProcess/Inspector/UIProcessForwardingFrontendChannel.h
R Source/WebKit/WebProcess/Inspector/WebFrameInspectorTarget.cpp
R Source/WebKit/WebProcess/Inspector/WebFrameInspectorTarget.h
R
Source/WebKit/WebProcess/Inspector/WebFrameInspectorTargetFrontendChannel.cpp
R
Source/WebKit/WebProcess/Inspector/WebFrameInspectorTargetFrontendChannel.h
R Source/WebKit/WebProcess/Inspector/WebPageInspectorTarget.cpp
R Source/WebKit/WebProcess/Inspector/WebPageInspectorTarget.h
R
Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetFrontendChannel.cpp
R Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetFrontendChannel.h
M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
M Source/WebKit/WebProcess/WebPage/WebFrame.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
Log Message:
-----------
Web Inspector: Rename WebPageInspectorTarget to PageInspectorTarget
https://bugs.webkit.org/show_bug.cgi?id=308092
Reviewed by BJ Burg.
Given {WebPage, Page, Frame}InspectorControllers control the {WebPage,
Page, Frame} target types respectively, it's confusing to have
{WebPage, WebFrame}InspectorTargets represent {Page, Frame}Targets.
Rename the targets and their proxies for consistency.
Meanwhile, Web{Page, Frame}InspectorTargetFrontendChannels are used
in very similar ways. Combine them into one UIProcessForwardingFrontendChannel.
This refactoring should make introducing the worker target simpler and
more consistent as well, where we wouldn't need to add a "Web" prefix or
create another special frontend channel type with the same function.
* Source/WebKit/Sources.txt:
* Source/WebKit/UIProcess/Inspector/FrameInspectorTargetProxy.cpp: Renamed from
Source/WebKit/UIProcess/Inspector/WebFrameInspectorTargetProxy.cpp.
(WebKit::FrameInspectorTargetProxy::create):
(WebKit::FrameInspectorTargetProxy::FrameInspectorTargetProxy):
(WebKit::FrameInspectorTargetProxy::connect):
(WebKit::FrameInspectorTargetProxy::disconnect):
(WebKit::FrameInspectorTargetProxy::sendMessageToTargetBackend):
(WebKit::FrameInspectorTargetProxy::didCommitProvisionalTarget):
(WebKit::FrameInspectorTargetProxy::isProvisional const):
* Source/WebKit/UIProcess/Inspector/FrameInspectorTargetProxy.h: Renamed from
Source/WebKit/UIProcess/Inspector/WebFrameInspectorTargetProxy.h.
(isType):
* Source/WebKit/UIProcess/Inspector/InspectorTargetProxy.cpp:
* Source/WebKit/UIProcess/Inspector/PageInspectorTargetProxy.cpp: Renamed from
Source/WebKit/UIProcess/Inspector/WebPageInspectorTargetProxy.cpp.
(WebKit::PageInspectorTargetProxy::create):
(WebKit::PageInspectorTargetProxy::PageInspectorTargetProxy):
(WebKit::PageInspectorTargetProxy::connect):
(WebKit::PageInspectorTargetProxy::disconnect):
(WebKit::PageInspectorTargetProxy::sendMessageToTargetBackend):
(WebKit::PageInspectorTargetProxy::didCommitProvisionalTarget):
(WebKit::PageInspectorTargetProxy::isProvisional const):
* Source/WebKit/UIProcess/Inspector/PageInspectorTargetProxy.h: Renamed from
Source/WebKit/UIProcess/Inspector/WebPageInspectorTargetProxy.h.
(isType):
* Source/WebKit/UIProcess/Inspector/WebPageInspectorController.cpp:
(WebKit::getTargetID):
(WebKit::WebPageInspectorController::init):
(WebKit::WebPageInspectorController::didCreateProvisionalPage):
(WebKit::WebPageInspectorController::didCommitProvisionalPage):
(WebKit::WebPageInspectorController::didCreateFrame):
(WebKit::WebPageInspectorController::willDestroyFrame):
* Source/WebKit/UIProcess/WebFrameProxy.cpp:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Inspector/FrameInspectorTarget.cpp: Renamed from
Source/WebKit/WebProcess/Inspector/WebFrameInspectorTarget.cpp.
(WebKit::FrameInspectorTarget::FrameInspectorTarget):
(WebKit::FrameInspectorTarget::identifier const):
(WebKit::FrameInspectorTarget::connect):
(WebKit::FrameInspectorTarget::disconnect):
(WebKit::FrameInspectorTarget::sendMessageToTargetBackend):
(WebKit::FrameInspectorTarget::toTargetID):
* Source/WebKit/WebProcess/Inspector/FrameInspectorTarget.h: Renamed from
Source/WebKit/WebProcess/Inspector/WebFrameInspectorTarget.h.
* Source/WebKit/WebProcess/Inspector/PageInspectorTarget.cpp: Renamed from
Source/WebKit/WebProcess/Inspector/WebPageInspectorTarget.cpp.
(WebKit::PageInspectorTarget::PageInspectorTarget):
(WebKit::PageInspectorTarget::identifier const):
(WebKit::PageInspectorTarget::connect):
(WebKit::PageInspectorTarget::disconnect):
(WebKit::PageInspectorTarget::sendMessageToTargetBackend):
(WebKit::PageInspectorTarget::toTargetID):
* Source/WebKit/WebProcess/Inspector/PageInspectorTarget.h: Renamed from
Source/WebKit/WebProcess/Inspector/WebPageInspectorTarget.h.
* Source/WebKit/WebProcess/Inspector/UIProcessForwardingFrontendChannel.cpp:
Renamed from
Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetFrontendChannel.cpp.
(WebKit::UIProcessForwardingFrontendChannel::UIProcessForwardingFrontendChannel):
(WebKit::UIProcessForwardingFrontendChannel::sendMessageToFrontend):
* Source/WebKit/WebProcess/Inspector/UIProcessForwardingFrontendChannel.h:
Renamed from
Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetFrontendChannel.h.
*
Source/WebKit/WebProcess/Inspector/WebFrameInspectorTargetFrontendChannel.cpp:
Removed.
* Source/WebKit/WebProcess/Inspector/WebFrameInspectorTargetFrontendChannel.h:
Removed.
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::ensureInspectorTarget):
* Source/WebKit/WebProcess/WebPage/WebFrame.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::ensureInspectorTarget):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
Canonical link: https://commits.webkit.org/307840@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
