Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 763e36f74c98805f14a6a5d5a33fbe3cec115d16
https://github.com/WebKit/WebKit/commit/763e36f74c98805f14a6a5d5a33fbe3cec115d16
Author: Roberto Rodriguez <[email protected]>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
A LayoutTests/webgl/drawbuffers-before-attachment-expected.txt
A LayoutTests/webgl/drawbuffers-before-attachment.html
A LayoutTests/webgl/drawbuffers-extension-after-setup-expected.txt
A LayoutTests/webgl/drawbuffers-extension-after-setup.html
A LayoutTests/webgl/webgl2-drawbuffers-before-attachment-expected.txt
A LayoutTests/webgl/webgl2-drawbuffers-before-attachment.html
A LayoutTests/webgl/webgl2-drawbuffers-default-expected.txt
A LayoutTests/webgl/webgl2-drawbuffers-default.html
M Source/WebCore/html/canvas/WebGLFramebuffer.cpp
M Source/WebCore/html/canvas/WebGLFramebuffer.h
M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
Log Message:
-----------
[WebGL] Remove redundant m_filteredDrawBuffers code
https://bugs.webkit.org/show_bug.cgi?id=307622
rdar://170192162
Reviewed by Dan Glastonbury.
The m_filteredDrawBuffers mechanism was added to work around a macOS native
OpenGL
driver bug. Since WebKit uses ANGLE exclusively for its implementation since
2022, this filtering is
redundant - ANGLE handles unattached draw buffer filtering internally during
rendering.
This simplifies the code by removing:
- m_filteredDrawBuffers and m_drawBufferStatePendingSync members
- updateFilteredDrawBuffers() method
- applyFilteredDrawBuffers() method and its call site in setFramebuffer()
- Draw buffer handling in setAttachmentForBoundFramebuffer() and
removeAttachmentFromBoundFramebuffer()
Tests: webgl/drawbuffers-before-attachment.html
webgl/drawbuffers-extension-after-setup.html
webgl/webgl2-drawbuffers-before-attachment.html
webgl/webgl2-drawbuffers-default.html
* LayoutTests/webgl/drawbuffers-before-attachment-expected.txt: Added.
* LayoutTests/webgl/drawbuffers-before-attachment.html: Added.
* LayoutTests/webgl/drawbuffers-extension-after-setup-expected.txt: Added.
* LayoutTests/webgl/drawbuffers-extension-after-setup.html: Added.
* LayoutTests/webgl/webgl2-drawbuffers-before-attachment-expected.txt: Added.
* LayoutTests/webgl/webgl2-drawbuffers-before-attachment.html: Added.
* LayoutTests/webgl/webgl2-drawbuffers-default-expected.txt: Added.
* LayoutTests/webgl/webgl2-drawbuffers-default.html: Added.
* Source/WebCore/html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::drawBuffers):
(WebCore::WebGLFramebuffer::applyFilteredDrawBuffers): Deleted.
(WebCore::WebGLFramebuffer::updateFilteredDrawBuffers): Deleted.
* Source/WebCore/html/canvas/WebGLFramebuffer.h:
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::setFramebuffer):
Canonical link: https://commits.webkit.org/308079@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
