Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 443b8878fd9ad60bfaaf3d5adcf54a5ac7e3181e
https://github.com/WebKit/WebKit/commit/443b8878fd9ad60bfaaf3d5adcf54a5ac7e3181e
Author: Charlie Wolfe <[email protected]>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/incorrectCreateTableSchema.db
Log Message:
-----------
TestWebKitAPI.ResourceLoadStatistics.MigrateDataFromIncorrectCreateTableSchema
is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=308477
rdar://171006242
Reviewed by Pascoe.
This test needed the following fixes to fix the flakiness:
- Use a fresh non-default WKWebsiteDataStore with a temp directory instead of
defaultDataStore,
which is a singleton whose database directory can still be held open by the
previous iteration's
network process.
- Enable third-party cookie blocking. When third-party cookie blocking is not
enabled, database
queries will only match domains marked as prevalent. This test should enable
it so that queries
always return all domains.
- Wait for navigation to finish before issuing ITP queries.
- Populate TopLevelDomains in the pre-seeded database so that INSERT OR
REPLACE into
SubresourceUnderTopFrameDomains does not fail the foreign key constraint on
topFrameDomainID
REFERENCES TopLevelDomains.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
(TEST(ResourceLoadStatistics, MigrateDataFromIncorrectCreateTableSchema)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/incorrectCreateTableSchema.db:
Canonical link: https://commits.webkit.org/308097@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
