Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bd2f4d1c9a01b4c6d7325ef8ca1149ed64a68829
https://github.com/WebKit/WebKit/commit/bd2f4d1c9a01b4c6d7325ef8ca1149ed64a68829
Author: Tyler Wilcock <[email protected]>
Date: 2026-02-24 (Tue, 24 Feb 2026)
Changed paths:
A LayoutTests/accessibility/spinbutton-inside-collapsed-details-expected.txt
A LayoutTests/accessibility/spinbutton-inside-collapsed-details.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilitySpinButton.cpp
M Source/WebCore/accessibility/AccessibilitySpinButton.h
M Source/WebCore/accessibility/AccessibilitySpinButtonPart.cpp
M Source/WebCore/accessibility/AccessibilitySpinButtonPart.h
Log Message:
-----------
AX: number stepper within collapsed details element in accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=307508
rdar://170106659
Reviewed by Joshua Hoffman.
AccessibilitySpinButton and AccessibilitySpinButtonPart used the default
AccessibilityMockObject computeIsIgnored() implementation, which is not
correct when inside a content-visibility:hidden container (as in the
case of a collapsed details element).
We also need to make sure the AccessibilitySpinButton is fully set up
with its role and spinButtonElement before creating the child
AccessibilitySpinButtonParts, as they now rely on their parent for
computing the correct is-ignored value, who in turn relies on its
role and element for computing the correct is-ignored value.
* LayoutTests/accessibility/spinbutton-inside-collapsed-details-expected.txt:
Added.
* LayoutTests/accessibility/spinbutton-inside-collapsed-details.html: Added.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::create):
(WebCore::AXObjectCache::createSpinButton):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
* Source/WebCore/accessibility/AccessibilitySpinButton.cpp:
(WebCore::AccessibilitySpinButton::AccessibilitySpinButton):
(WebCore::AccessibilitySpinButton::create):
(WebCore::AccessibilitySpinButton::computeIsIgnored const):
(WebCore::AccessibilitySpinButton::incrementButton): Deleted.
(WebCore::AccessibilitySpinButton::decrementButton): Deleted.
* Source/WebCore/accessibility/AccessibilitySpinButton.h:
* Source/WebCore/accessibility/AccessibilitySpinButtonPart.cpp:
(WebCore::AccessibilitySpinButtonPart::computeIsIgnored const):
* Source/WebCore/accessibility/AccessibilitySpinButtonPart.h:
Canonical link: https://commits.webkit.org/308165@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
