Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: aba6057fd09438d4902b0aa01c348e1208da87aa
https://github.com/WebKit/WebKit/commit/aba6057fd09438d4902b0aa01c348e1208da87aa
Author: Sammy Gill <[email protected]>
Date: 2026-02-24 (Tue, 24 Feb 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/grid/GridFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/grid/GridFormattingContext.h
M Source/WebCore/layout/formattingContexts/grid/PlacedGridItem.cpp
M Source/WebCore/layout/formattingContexts/grid/PlacedGridItem.h
Log Message:
-----------
[GFC][Cleanup] Tidy up PlacedGridItem construction a bit
https://bugs.webkit.org/show_bug.cgi?id=308504
rdar://171024379
Reviewed by Elika Etemad.
Currently, inside of GridFormattingContext::constructPlacedGridItems
much of the space is taken up by grabbing things off of the grid item's
style, potentially constructing some side structure, and passing the
data into the PlacedGridItemConstructor. Since this adds quite a bit of
noise to the rest of the implementation of this function and these are
fairly straightforward operations, we can just pass off this
responsibility to the constructor. The constructor can take in the
RenderStyles for the grid container and item to grab off whatever bits
that are needed. We continue to refrain from holding onto the
RenderStyle and BoxGeometry directly so that PlacedGridItem stays well
defined with just the data that is needed.
Canonical link: https://commits.webkit.org/308172@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
