Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ca3b56d49b323f7aa52bcf48a61fc369020d6078
https://github.com/WebKit/WebKit/commit/ca3b56d49b323f7aa52bcf48a61fc369020d6078
Author: Fujii Hironori <[email protected]>
Date: 2026-03-08 (Sun, 08 Mar 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/crashtests/div-in-hidden.html
M Source/WebCore/rendering/RenderBox.cpp
Log Message:
-----------
ASSERTION FAILED: !isSkippedContentRoot(*this) in
WebCore::RenderBox::foregroundIsKnownToBeOpaqueInRect
https://bugs.webkit.org/show_bug.cgi?id=307963
Reviewed by Alan Baradlay.
An assertion failed in RenderBox::foregroundIsKnownToBeOpaqueInRect(). It
asserts `this` is not a skipped content root because a skipped content root
paints no foregrounds and never obscure the background.
In foregroundIsKnownToBeOpaqueInRect(), if isSkippedContentRoot(childBox), we
shound't recursively call childBox.foregroundIsKnownToBeOpaqueInRect().
RenderBox::computeBackgroundIsKnownToBeObscured also calls
foregroundIsKnownToBeOpaqueInRect(). However, in this functions, `this` is not
a skipped content root. Added an assertion to ensure that.
Test:
imported/w3c/web-platform-tests/css/css-contain/content-visibility/crashtests/div-in-hidden.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/crashtests/div-in-hidden.html:
Added.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::foregroundIsKnownToBeOpaqueInRect const):
(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured):
Canonical link: https://commits.webkit.org/308897@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
