Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 34907dcd9751afe99d82629ecb71627318113221
https://github.com/WebKit/WebKit/commit/34907dcd9751afe99d82629ecb71627318113221
Author: Adrian Taylor <[email protected]>
Date: 2026-03-09 (Mon, 09 Mar 2026)
Changed paths:
M Source/WebCore/platform/graphics/Color.h
Log Message:
-----------
Fix Color linker issue
https://bugs.webkit.org/show_bug.cgi?id=309451
rdar://172026177
Reviewed by Richard Robinson.
This static symbol is not mentioned in any .cpp file so is not defined for
'ODR-use'. Most compiles seem to survive this with no issues, but for some
reason when enabling some Swift features, it causes other Swift features to
(presumably) be optimised in a different way that results in this symbol being
undefined at link time.
The obvious fix is to add an 'inline' keyword or alternatively to add
a definition of this symbol in a .cpp file, but both of these would require
exporting the symbol from WebCore using WEBCORE_EXPORT. Instead, for
the only place it's actually used in an 'ODR-use' way, cease to do so
and apply lvalue-to-rvalue conversion instead, then there's no need to
export the symbol from WebCore.
Canonical link: https://commits.webkit.org/308901@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
