Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 230771c93ca1c72406ef0a93bd5709af34f05525
https://github.com/WebKit/WebKit/commit/230771c93ca1c72406ef0a93bd5709af34f05525
Author: Ahmad Saleem <[email protected]>
Date: 2026-03-16 (Mon, 16 Mar 2026)
Changed paths:
M LayoutTests/fast/events/mouse-cursor-expected.txt
M LayoutTests/fast/events/mouse-cursor.html
R
LayoutTests/platform/gtk/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png
R
LayoutTests/platform/gtk/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png
R
LayoutTests/platform/ios/svg/webarchive/svg-cursor-subresources-expected.txt
R
LayoutTests/platform/mac-tahoe-wk2-pixel/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png
R
LayoutTests/platform/mac-tahoe-wk2-pixel/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png
R
LayoutTests/platform/mac-tahoe-wk2-pixel/svg/webarchive/svg-cursor-subresources-expected.png
R
LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png
R
LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png
R
LayoutTests/platform/mac/svg/webarchive/svg-cursor-subresources-expected.png
R
LayoutTests/platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt
M LayoutTests/svg/custom/global-constructors-expected.txt
M LayoutTests/svg/custom/global-constructors.html
R LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.txt
R LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-x-attr.html
R LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.txt
R LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-y-attr.html
R LayoutTests/svg/webarchive/svg-cursor-subresources-expected.webarchive
R LayoutTests/svg/webarchive/svg-cursor-subresources.svg
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSCursorImageValue.cpp
M Source/WebCore/style/values/images/kinds/StyleCursorImage.cpp
M Source/WebCore/style/values/images/kinds/StyleCursorImage.h
R Source/WebCore/svg/SVGCursorElement.cpp
R Source/WebCore/svg/SVGCursorElement.h
M Source/WebCore/svg/SVGElementRareData.h
M Source/WebCore/svg/svgtags.in
Log Message:
-----------
[SVG2] Remove `SVGCursorElement`
https://bugs.webkit.org/show_bug.cgi?id=304383
rdar://167158212
Reviewed by Anne van Kesteren.
The SVG cursor element was removed from the SVG2 specification [1][2].
WebKit stopped exposing it to the web in 2022 [3], mapping the tag to
a plain SVGElement in svgtags.in. This patch completes the removal by
deleting the SVGCursorElement class and its integration with
Style::CursorImage.
Blink removed SVGCursorElement in 2016 [4].
[1] https://svgwg.org/svg2-draft/changes.html#interact
[2] https://github.com/w3c/svgwg/issues/449
[3] https://commits.webkit.org/255702@main
[4]
https://chromium.googlesource.com/chromium/src.git/+/f63d67df608751f83eaa15a67df069a38714f171
* LayoutTests/fast/events/mouse-cursor-expected.txt:
* LayoutTests/fast/events/mouse-cursor.html:
*
LayoutTests/platform/gtk/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png:
Removed.
*
LayoutTests/platform/gtk/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png:
Removed.
* LayoutTests/platform/ios/svg/webarchive/svg-cursor-subresources-expected.txt:
Removed.
*
LayoutTests/platform/mac-tahoe-wk2-pixel/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png:
Removed.
*
LayoutTests/platform/mac-tahoe-wk2-pixel/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png:
Removed.
*
LayoutTests/platform/mac-tahoe-wk2-pixel/svg/webarchive/svg-cursor-subresources-expected.png:
Removed.
*
LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png:
Removed.
*
LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png:
Removed.
* LayoutTests/platform/mac/svg/webarchive/svg-cursor-subresources-expected.png:
Removed.
* LayoutTests/platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt:
Removed.
* LayoutTests/svg/custom/global-constructors-expected.txt:
* LayoutTests/svg/custom/global-constructors.html:
* LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.txt:
Removed.
* LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-x-attr.html: Removed.
* LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.txt:
Removed.
* LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-y-attr.html: Removed.
* LayoutTests/svg/webarchive/svg-cursor-subresources-expected.webarchive:
Removed.
* LayoutTests/svg/webarchive/svg-cursor-subresources.svg: Removed.
* Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSCursorImageValue.cpp:
* Source/WebCore/style/values/images/kinds/StyleCursorImage.cpp:
(WebCore::Style::CursorImage::selectBestFitImage):
(WebCore::Style::CursorImage::~CursorImage): Deleted.
(WebCore::Style::CursorImage::updateCursorElement): Deleted.
(WebCore::Style::CursorImage::cursorElementRemoved): Deleted.
(WebCore::Style::CursorImage::cursorElementChanged): Deleted.
* Source/WebCore/style/values/images/kinds/StyleCursorImage.h:
* Source/WebCore/svg/SVGCursorElement.cpp: Removed.
* Source/WebCore/svg/SVGCursorElement.h: Removed.
* Source/WebCore/svg/SVGElementRareData.h:
* Source/WebCore/svg/svgtags.in:
Canonical link: https://commits.webkit.org/309308@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
