Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c9a5ef901a472d491aca0ae140c21250e3f3cc11
https://github.com/WebKit/WebKit/commit/c9a5ef901a472d491aca0ae140c21250e3f3cc11
Author: Sihui Liu <[email protected]>
Date: 2026-03-16 (Mon, 16 Mar 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/EnhancedSecurity.mm
Log Message:
-----------
[Site Isolation] Fix EnhancedSecurity.PSONToEnhancedSecurity
https://bugs.webkit.org/show_bug.cgi?id=309999
rdar://172638545
Reviewed by Rupin Mittal.
EnhancedSecurity has different behavior under Site Isolation, specifically:
1. Without Site Isolation, all frames in a page are loaded in the same process,
so process (process variant) will not
change after subframe navigation. With Site Isolation, frames can be loaded in
different processes, so it can change.
2. Without Site Isolation, if enhanced security state of a navigation does not
match that of current process, we can
swap process to use a process with matching variant. With Site Isolation, the
process is selected based on site -- if
a process for the site already exists in the browsing context group, we have to
use that process since the navigating
frame will need sync access to same-origin frames in the same group. See
306717@main.
Therefore, we should update the existing tests with different expectations
under Site Isolation (so they won't end up
failing when Site Isolation is on).
* Tools/TestWebKitAPI/Tests/WebKitCocoa/EnhancedSecurity.mm:
(TestWebKitAPI::TEST(EnhancedSecurity, PSONToEnhancedSecurity)):
(TestWebKitAPI::TEST(EnhancedSecurity, PSONToEnhancedSecuritySamePage)):
(TestWebKitAPI::TEST(EnhancedSecurity,
EnhancedSecurityNavigationStaysEnabledAfterSubFrameNavigationRequestDisablesCrossOrigin)):
(TestWebKitAPI::TEST(EnhancedSecurity,
EnhancedSecurityNavigationStaysDisabledAfterSubFrameNavigationRequestEnabledCrossOrigin)):
Canonical link: https://commits.webkit.org/309341@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
