[webkit-changes] [WebKit/WebKit] dfbeb5: [Site Isolation] Color inputs are broken when insi...

[Zak Ridouh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dfbeb554431a02fbf454b515ade04059e4ddbd78
      
https://github.com/WebKit/WebKit/commit/dfbeb554431a02fbf454b515ade04059e4ddbd78
  Author: Zak Ridouh <z...@apple.com>
  Date:   2026-03-16 (Mon, 16 Mar 2026)

  Changed paths:
    A 
LayoutTests/http/tests/site-isolation/color-input-cross-origin-iframe-expected.txt
    A LayoutTests/http/tests/site-isolation/color-input-cross-origin-iframe.html
    A LayoutTests/http/tests/site-isolation/resources/color-input-iframe.html
    M LayoutTests/resources/ui-helper.js
    M Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp
    M Source/WebKit/UIProcess/API/gtk/PageClientImpl.h
    M Source/WebKit/UIProcess/API/gtk/WebKitColorChooser.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitColorChooser.h
    M Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp
    M Source/WebKit/UIProcess/API/wpe/PageClientImpl.h
    M Source/WebKit/UIProcess/PageClient.h
    M Source/WebKit/UIProcess/WebColorPicker.cpp
    M Source/WebKit/UIProcess/WebColorPicker.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/gtk/WebColorPickerGtk.cpp
    M Source/WebKit/UIProcess/gtk/WebColorPickerGtk.h
    M Source/WebKit/UIProcess/ios/PageClientImplIOS.h
    M Source/WebKit/UIProcess/mac/PageClientImplMac.h
    M Source/WebKit/UIProcess/mac/PageClientImplMac.mm
    M Source/WebKit/UIProcess/mac/WebColorPickerMac.h
    M Source/WebKit/UIProcess/mac/WebColorPickerMac.mm
    M Source/WebKit/UIProcess/playstation/PageClientImpl.h
    M Source/WebKit/UIProcess/win/PageClientImpl.h

  Log Message:
  -----------
  [Site Isolation] Color inputs are broken when inside a cross-origin iframe
https://bugs.webkit.org/show_bug.cgi?id=307726
rdar://164540461

Reviewed by Aditya Keerthi.

Store the frame ID when showing the color picker and use
sendToProcessContainingFrame() for DidChooseColor and DidEndColorPicker
messages, matching the pattern used for datetime pickers.

* 
LayoutTests/http/tests/site-isolation/color-input-cross-origin-iframe-expected.txt:
 Added.
* LayoutTests/http/tests/site-isolation/color-input-cross-origin-iframe.html: 
Added.
* LayoutTests/http/tests/site-isolation/resources/color-input-iframe.html: 
Added.
* LayoutTests/resources/ui-helper.js:
(window.UIHelper.activateFormControl):
(window.UIHelper.activateFormControl.return.new.Promise.): Deleted.
(window.UIHelper.activateFormControl.return.new.Promise): Deleted.
* Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createColorPicker):
* Source/WebKit/UIProcess/API/gtk/PageClientImpl.h:
* Source/WebKit/UIProcess/API/gtk/WebKitColorChooser.cpp:
(WebKit::WebKitColorChooser::create):
(WebKit::WebKitColorChooser::WebKitColorChooser):
* Source/WebKit/UIProcess/API/gtk/WebKitColorChooser.h:
* Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp:
(WebKit::PageClientImpl::createColorPicker):
* Source/WebKit/UIProcess/API/wpe/PageClientImpl.h:
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/WebColorPicker.cpp:
(WebKit::WebColorPicker::WebColorPicker):
* Source/WebKit/UIProcess/WebColorPicker.h:
(WebKit::WebColorPicker::frameID const):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showColorPicker):
(WebKit::WebPageProxy::Internals::didChooseColor):
(WebKit::WebPageProxy::Internals::didEndColorPicker):
* Source/WebKit/UIProcess/gtk/WebColorPickerGtk.cpp:
(WebKit::WebColorPickerGtk::create):
(WebKit::WebColorPickerGtk::WebColorPickerGtk):
* Source/WebKit/UIProcess/gtk/WebColorPickerGtk.h:
* Source/WebKit/UIProcess/ios/PageClientImplIOS.h:
* Source/WebKit/UIProcess/mac/PageClientImplMac.h:
* Source/WebKit/UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::createColorPicker):
* Source/WebKit/UIProcess/mac/WebColorPickerMac.h:
* Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:
(WebKit::WebColorPickerMac::create):
(WebKit::WebColorPickerMac::WebColorPickerMac):
* Source/WebKit/UIProcess/playstation/PageClientImpl.h:
* Source/WebKit/UIProcess/win/PageClientImpl.h:

Canonical link: https://commits.webkit.org/309358@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications