Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ae5f3fc8a4f1f83c4b3b9c04018fd15cd3f3be71
https://github.com/WebKit/WebKit/commit/ae5f3fc8a4f1f83c4b3b9c04018fd15cd3f3be71
Author: Wenson Hsieh <[email protected]>
Date: 2026-03-16 (Mon, 16 Mar 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm
M Tools/TestWebKitAPI/cocoa/app/AppCommon.mm
Log Message:
-----------
REGRESSION(308411@main): [macOS Debug]
TestWebKitAPI.EditorStateTests.TypingAttributesTextAlignmentDirectionalText is
flaky failure
https://bugs.webkit.org/show_bug.cgi?id=309007
rdar://171554884
Reviewed by Aditya Keerthi.
The logging previously added in https://commits.webkit.org/308411@main caused
some subsequent tests
to fail with `EXCEEDED LOG LINE THRESHOLD OF 250`. When
`ScrollingTreeAfterDetachReattach` times
out, we never actually got to the `-removeObjectForKey:` calls in the bottom of
the test; as a
result, the logging channels would be enabled for subsequent tests, causing
spurious failures if a
downstream test happened to trigger lots of debug logging.
Since the scrolling test was already disabled in 308806@main, we can actually
just reenable these
two otherwise-unrelated `EditorState` API tests. I'm also adding a bit of logic
in this patch to
prevent similar issues in the future, by having `initializeApp()` force the
logging channels off at
the start of each test.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
(TestWebKitAPI::TEST(EditorStateTests, TypingAttributesTextAlignmentStartEnd)):
(TestWebKitAPI::TEST(EditorStateTests,
TypingAttributesTextAlignmentDirectionalText)):
* Tools/TestWebKitAPI/cocoa/app/AppCommon.mm:
(TestWebKitAPI::initializeApp):
Canonical link: https://commits.webkit.org/309365@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
