Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a38bde2a7275eafbec36dbe6e30ca18bb4bdaf59
https://github.com/WebKit/WebKit/commit/a38bde2a7275eafbec36dbe6e30ca18bb4bdaf59
Author: Ahmad Saleem <[email protected]>
Date: 2026-03-17 (Tue, 17 Mar 2026)
Changed paths:
R LayoutTests/fast/svg/SVGViewSpec-viewTarget-expected.txt
R LayoutTests/fast/svg/SVGViewSpec-viewTarget.svg
M LayoutTests/svg/dom/SVGViewSpec-defaults-expected.txt
M LayoutTests/svg/dom/SVGViewSpec-defaults.html
M LayoutTests/svg/dom/SVGViewSpec-expected.txt
M LayoutTests/svg/dom/SVGViewSpec-invalid-ref-crash-expected.txt
M LayoutTests/svg/dom/SVGViewSpec-invalid-ref-crash.html
M LayoutTests/svg/dom/SVGViewSpec-multiple-views-expected.txt
M LayoutTests/svg/dom/SVGViewSpec-multiple-views.html
M LayoutTests/svg/dom/SVGViewSpec.html
M LayoutTests/svg/dom/viewspec-parser-1-expected.txt
M LayoutTests/svg/dom/viewspec-parser-2-expected.txt
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/svg/SVGViewSpec.cpp
M Source/WebCore/svg/SVGViewSpec.h
M Source/WebCore/svg/SVGViewSpec.idl
Log Message:
-----------
[SVG2] Remove viewTarget from SVGViewSpec
https://bugs.webkit.org/show_bug.cgi?id=309974
rdar://172590438
Reviewed by Nikolas Zimmermann.
Per SVG2 spec changes (https://svgwg.org/svg2-draft/changes.html#types),
the 'viewTarget' attribute on the 'view' element and the corresponding
SVG view fragment parameter have been removed.
This removes the viewTarget() and viewTargetString() APIs and the
m_viewTargetString member from SVGViewSpec, and removes both attributes
from SVGViewSpec.idl.
The viewTarget parameter is still skipped over (but no longer stored)
during SVG view fragment parsing in parseViewSpec(), so that existing
content using svgView() fragments with viewTarget(...) continues to
parse the remaining parameters (viewBox, transform, etc.) correctly.
The viewTargetAttr definition in svgattrs.in is intentionally kept
because it is referenced by HTMLTreeBuilder for the HTML parser's SVG
attribute case adjustment step, which is required by the HTML
specification and validated by html5lib parser tests.
* LayoutTests/fast/svg/SVGViewSpec-viewTarget-expected.txt: Removed.
* LayoutTests/fast/svg/SVGViewSpec-viewTarget.svg: Removed.
* LayoutTests/svg/dom/SVGViewSpec-defaults-expected.txt:
* LayoutTests/svg/dom/SVGViewSpec-defaults.html:
* LayoutTests/svg/dom/SVGViewSpec-expected.txt:
* LayoutTests/svg/dom/SVGViewSpec-invalid-ref-crash-expected.txt:
* LayoutTests/svg/dom/SVGViewSpec-invalid-ref-crash.html:
* LayoutTests/svg/dom/SVGViewSpec-multiple-views-expected.txt:
* LayoutTests/svg/dom/SVGViewSpec-multiple-views.html:
* LayoutTests/svg/dom/SVGViewSpec.html:
* LayoutTests/svg/dom/viewspec-parser-1-expected.txt:
* LayoutTests/svg/dom/viewspec-parser-2-expected.txt:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::reset):
(WebCore::SVGViewSpec::parseViewSpec):
(WebCore::SVGViewSpec::viewTarget const): Deleted.
* Source/WebCore/svg/SVGViewSpec.h:
* Source/WebCore/svg/SVGViewSpec.idl:
Canonical link: https://commits.webkit.org/309424@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
