Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 99fee9e9322277f43c1c869cb5f8fb27ecaf6d3a
https://github.com/WebKit/WebKit/commit/99fee9e9322277f43c1c869cb5f8fb27ecaf6d3a
Author: Yulun Wu <[email protected]>
Date: 2026-03-18 (Wed, 18 Mar 2026)
Changed paths:
M LayoutTests/fast/lists/list-marker-before-content-table-expected.txt
M
LayoutTests/fast/lists/list-marker-outside-flex-collapse-anonymous-block-expected.html
M
LayoutTests/fast/lists/list-marker-outside-flex-collapse-anonymous-block.html
M
LayoutTests/platform/glib/fast/css-generated-content/table-row-group-with-before-expected.txt
M
LayoutTests/platform/glib/fast/css-generated-content/table-row-with-before-expected.txt
M
LayoutTests/platform/glib/fast/css-generated-content/table-with-before-expected.txt
M LayoutTests/platform/glib/fast/forms/form-hides-table-expected.txt
M
LayoutTests/platform/glib/fast/lists/ordered-list-with-no-ol-tag-expected.txt
M
LayoutTests/platform/ios/fast/css-generated-content/table-row-group-with-before-expected.txt
M
LayoutTests/platform/ios/fast/css-generated-content/table-row-with-before-expected.txt
M
LayoutTests/platform/ios/fast/css-generated-content/table-with-before-expected.txt
M LayoutTests/platform/ios/fast/forms/form-hides-table-expected.txt
M
LayoutTests/platform/ios/fast/lists/ordered-list-with-no-ol-tag-expected.txt
M
LayoutTests/platform/mac/fast/css-generated-content/table-row-group-with-before-expected.txt
M
LayoutTests/platform/mac/fast/css-generated-content/table-row-with-before-expected.txt
M
LayoutTests/platform/mac/fast/css-generated-content/table-with-before-expected.txt
M LayoutTests/platform/mac/fast/forms/form-hides-table-expected.txt
M
LayoutTests/platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.txt
M Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp
Log Message:
-----------
[List Marker]Collapse AnonymousBlock created when block content prevents
line-box parenting.
https://bugs.webkit.org/show_bug.cgi?id=310046
<rdar://172686060>
Reviewed by Alan Baradlay.
309272@main fixed a bug where inline item blockification caused
findParentOfEmptyOrFirstLineBox to fail to find a valid line box parent.
This caused us to create an anonymous block to parent the list marker
which inherited line height and pushed the visual content down and
no longer next to the list marker.
This PR builds on that fix by expanding the line collapse behavior to
encompass anonymous blocks created by actual block items instead
of only inline items that were converted to block items, fixing
the behavior for "display: block"
This PR also fixes incorrect test expecatations for:
table-row-group-with-before.html
table-row-with-before.html
table-with-before.html
form-hides-table.html
list-marker-before-content-table.html
ordered-list-with-no-ol-tag.html
By collapsing the anonymous block to line up content with the list
marker, we now match the behavior with Chrome and Firefox.
* LayoutTests/fast/lists/list-marker-before-content-table-expected.txt:
*
LayoutTests/fast/lists/list-marker-outside-flex-collapse-anonymous-block-expected.html:
* LayoutTests/fast/lists/list-marker-outside-flex-collapse-anonymous-block.html:
*
LayoutTests/platform/glib/fast/css-generated-content/table-row-group-with-before-expected.txt:
*
LayoutTests/platform/glib/fast/css-generated-content/table-row-with-before-expected.txt:
*
LayoutTests/platform/glib/fast/css-generated-content/table-with-before-expected.txt:
* LayoutTests/platform/glib/fast/forms/form-hides-table-expected.txt:
* LayoutTests/platform/glib/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
*
LayoutTests/platform/ios/fast/css-generated-content/table-row-group-with-before-expected.txt:
*
LayoutTests/platform/ios/fast/css-generated-content/table-row-with-before-expected.txt:
*
LayoutTests/platform/ios/fast/css-generated-content/table-with-before-expected.txt:
* LayoutTests/platform/ios/fast/forms/form-hides-table-expected.txt:
* LayoutTests/platform/ios/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
*
LayoutTests/platform/mac/fast/css-generated-content/table-row-group-with-before-expected.txt:
*
LayoutTests/platform/mac/fast/css-generated-content/table-row-with-before-expected.txt:
*
LayoutTests/platform/mac/fast/css-generated-content/table-with-before-expected.txt:
* LayoutTests/platform/mac/fast/forms/form-hides-table-expected.txt:
* LayoutTests/platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
* Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp:
(WebCore::findParentOfEmptyOrFirstLineBox):
(WebCore::RenderTreeBuilder::List::updateItemMarker):
Canonical link: https://commits.webkit.org/309466@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
