Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 476f7053d6287342360ee4c6356b8011ab5addc2
https://github.com/WebKit/WebKit/commit/476f7053d6287342360ee4c6356b8011ab5addc2
Author: Megan Gardner <[email protected]>
Date: 2026-03-27 (Fri, 27 Mar 2026)
Changed paths:
M Source/WebCore/dom/DocumentMarkerController.cpp
M Source/WebCore/dom/DocumentMarkerController.h
Log Message:
-----------
Text effect continually reapplied unnecessarily.
https://bugs.webkit.org/show_bug.cgi?id=310917
rdar://173526354
Reviewed by Lily Spiniolas.
Since grammar suggestions are continuously generated
and the document markers are continually removed and
reapplied, the effect is also continuously applied,
when it should only be applied once. We need to keep
a separate list of applied effects so that they are
only applied the first time. I really would have liked
to use the presence of a document marker as a signal
that the effect does not need to be applied, but since
they are removed before reapplication, there is no way
to used their presence as a signal.
* Source/WebCore/dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::detach):
(WebCore::DocumentMarkerController::addMarker):
* Source/WebCore/dom/DocumentMarkerController.h:
Canonical link: https://commits.webkit.org/310132@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
