Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a5807ce0c94366e2ae2beea700326110e275a131
https://github.com/WebKit/WebKit/commit/a5807ce0c94366e2ae2beea700326110e275a131
Author: Richard Robinson <[email protected]>
Date: 2026-03-28 (Sat, 28 Mar 2026)
Changed paths:
M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
M Source/WebCore/PAL/pal/PALSwift/CryptoKitShim.swift
M Source/WebCore/PAL/pal/crypto/CryptoAlgorithmAESGCMCocoa.h
M Source/WebCore/PAL/pal/crypto/CryptoAlgorithmAESKWCocoaBridging.h
M Source/WebCore/PAL/pal/crypto/CryptoAlgorithmEd25519CocoaBridging.cpp
M Source/WebCore/PAL/pal/crypto/CryptoAlgorithmEd25519CocoaBridging.h
A Source/WebCore/PAL/pal/crypto/CryptoAlgorithmHKDFCocoaBridging.cpp
A Source/WebCore/PAL/pal/crypto/CryptoAlgorithmHKDFCocoaBridging.h
A Source/WebCore/PAL/pal/crypto/CryptoAlgorithmHMACCocoaBridging.cpp
A Source/WebCore/PAL/pal/crypto/CryptoAlgorithmHMACCocoaBridging.h
M Source/WebCore/PAL/pal/crypto/CryptoAlgorithmX25519CocoaBridging.cpp
M Source/WebCore/PAL/pal/crypto/CryptoAlgorithmX25519CocoaBridging.h
A Source/WebCore/PAL/pal/crypto/CryptoEDKeyBridging.cpp
A Source/WebCore/PAL/pal/crypto/CryptoEDKeyBridging.h
M Source/WebCore/PAL/pal/crypto/CryptoTypes.h
M Source/WebCore/PAL/pal/module.modulemap
M Source/WebCore/crypto/cocoa/CryptoAlgorithmHKDFCocoa.cpp
M Source/WebCore/crypto/cocoa/CryptoAlgorithmHMACCocoa.cpp
M Source/WebCore/crypto/cocoa/CryptoAlgorithmX25519Cocoa.cpp
M Source/WebCore/crypto/cocoa/CryptoKeyOKPCocoa.cpp
Log Message:
-----------
[Swift in WebKit] Non-PAL targets should not access the internal PAL Swift
bridging header (part 6)
https://bugs.webkit.org/show_bug.cgi?id=310930
rdar://173538464
Reviewed by Abrar Rahman Protyasha.
Remove the final usages of the internal PAL generated swift header from WebCore.
* Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:
* Source/WebCore/PAL/pal/PALSwift/CryptoKitShim.swift:
(EdKey.generatePrivateKey(_:)):
(EdKey.generatePrivateKeyKeyAgreement(_:)):
(EdKey.privateToPublic(_:privateKey:)):
(EdKey.validateKeyPair(_:privateKey:publicKey:)):
(EdKey.sign(_:privateKey:data:)):
- Move EdSigningAlgorithm and EdKeyAgreementAlgorithm to be agnostic C++ enums
* Source/WebCore/PAL/pal/crypto/CryptoAlgorithmEd25519CocoaBridging.cpp:
(PAL::Crypto::signEd25519CryptoKit):
(PAL::Crypto::verifyEd25519CryptoKit):
* Source/WebCore/PAL/pal/crypto/CryptoAlgorithmHKDFCocoaBridging.cpp: Copied
from Source/WebCore/PAL/pal/crypto/CryptoAlgorithmX25519CocoaBridging.cpp.
(PAL::Crypto::deriveBitsHKDFCryptoKit):
* Source/WebCore/PAL/pal/crypto/CryptoAlgorithmHKDFCocoaBridging.h: Copied from
Source/WebCore/PAL/pal/crypto/CryptoAlgorithmX25519CocoaBridging.h.
* Source/WebCore/PAL/pal/crypto/CryptoAlgorithmHMACCocoaBridging.cpp: Copied
from Source/WebCore/PAL/pal/crypto/CryptoAlgorithmX25519CocoaBridging.cpp.
(PAL::Crypto::signHMACCryptoKit):
(PAL::Crypto::verifyHMACCryptoKit):
* Source/WebCore/PAL/pal/crypto/CryptoAlgorithmHMACCocoaBridging.h: Copied from
Source/WebCore/PAL/pal/crypto/CryptoAlgorithmX25519CocoaBridging.h.
* Source/WebCore/PAL/pal/crypto/CryptoAlgorithmX25519CocoaBridging.cpp:
(PAL::Crypto::deriveBitsEd25519CryptoKit):
(PAL::Crypto::deriveBitsCryptoKit): Deleted.
* Source/WebCore/PAL/pal/crypto/CryptoAlgorithmX25519CocoaBridging.h:
* Source/WebCore/PAL/pal/crypto/CryptoEDKeyBridging.cpp: Copied from
Source/WebCore/PAL/pal/crypto/CryptoAlgorithmEd25519CocoaBridging.cpp.
(PAL::Crypto::EdKey::generatePrivateKey):
(PAL::Crypto::EdKey::generatePrivateKeyKeyAgreement):
(PAL::Crypto::EdKey::privateToPublic):
(PAL::Crypto::EdKey::privateToPublicKeyAgreement):
(PAL::Crypto::EdKey::validateKeyPair):
(PAL::Crypto::EdKey::validateKeyPairKeyAgreement):
* Source/WebCore/PAL/pal/crypto/CryptoEDKeyBridging.h: Copied from
Source/WebCore/PAL/pal/crypto/CryptoAlgorithmX25519CocoaBridging.h.
* Source/WebCore/PAL/pal/crypto/CryptoTypes.h:
* Source/WebCore/PAL/pal/module.modulemap:
* Source/WebCore/crypto/cocoa/CryptoAlgorithmHKDFCocoa.cpp:
(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):
(WebCore::platformDeriveBitsCryptoKit): Deleted.
* Source/WebCore/crypto/cocoa/CryptoAlgorithmHMACCocoa.cpp:
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
(WebCore::platformSignCryptoKit): Deleted.
(WebCore::platformVerifyCryptoKit): Deleted.
* Source/WebCore/crypto/cocoa/CryptoAlgorithmX25519Cocoa.cpp:
(WebCore::CryptoAlgorithmX25519::platformDeriveBits):
* Source/WebCore/crypto/cocoa/CryptoKeyOKPCocoa.cpp:
(WebCore::CryptoKeyOKP::platformGeneratePair):
(WebCore::CryptoKeyOKP::platformCheckPairedKeys):
(WebCore::CryptoKeyOKP::generateJwkX const):
Sink all these functions into PAL.
Canonical link: https://commits.webkit.org/310148@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
