Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1af4da6b6ac226b8f57b64d9288cea145b2dcd94
https://github.com/WebKit/WebKit/commit/1af4da6b6ac226b8f57b64d9288cea145b2dcd94
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-03-29 (Sun, 29 Mar 2026)
Changed paths:
M Source/WebCore/animation/StyleOriginatedAnimation.h
M Source/WebCore/animation/WebAnimation.h
Log Message:
-----------
Fix uninitialized member variables in WebAnimation and
StyleOriginatedAnimation
https://bugs.webkit.org/show_bug.cgi?id=311001
Reviewed by Antoine Quint.
Add default initializers to 4 member variables that were missing them,
while all surrounding members had proper initializers.
Valgrind trace:
==1173712== Conditional jump or move depends on uninitialised value(s)
==1173712== at 0x8652740:
WebCore::WebAnimation::updateFinishedState(WebCore::WebAnimation::DidSeek,
WebCore::WebAnimation::SynchronouslyNotify)
==1173712== by 0x8652FA0: WebCore::WebAnimation::runPendingPlayTask()
==1173712== by 0x86539A6: WebCore::WebAnimation::maybeMarkAsReady()
==1173712== by 0x8641449: WebCore::WebAnimation::tick()
==1173712== by 0x86413BA: WebCore::StyleOriginatedAnimation::tick()
==1173712== by 0x860BA17:
WebCore::AnimationTimelinesController::updateAnimationsAndSendEvents(WTF::Seconds)
==1173712== by 0x8AC1CBA: WebCore::Document::updateAnimationsAndSendEvents()
Covered by existing tests.
* Source/WebCore/animation/StyleOriginatedAnimation.h:
* Source/WebCore/animation/WebAnimation.h:
Canonical link: https://commits.webkit.org/310179@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
