Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 10f5b40c292e7707b4a1c5ee91368d94566abaa8
https://github.com/WebKit/WebKit/commit/10f5b40c292e7707b4a1c5ee91368d94566abaa8
Author: Ahmad Saleem <[email protected]>
Date: 2026-03-29 (Sun, 29 Mar 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-clock-value-out-of-range-minutes-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-clock-value-out-of-range-minutes.html
M Source/WebCore/svg/animation/SVGSMILElement.cpp
Log Message:
-----------
[SVG] SMIL parseClockValue should reject out-of-range minutes and seconds
https://bugs.webkit.org/show_bug.cgi?id=310971
rdar://173577212
Reviewed by Nikolas Zimmermann.
parseClockValue parses hours and minutes as uint8_t (0-255) with no
range check, and seconds via toDouble with no upper bound. Per the SMIL
timing spec [1], Minutes and Seconds in Full-clock-value (HH:MM:SS) and
Partial-clock-value (MM:SS) forms must be in the range 00-59. Values
like "01:99:01" or "30:99" were incorrectly accepted.
Add range validation for both minutes and seconds in both clock value forms.
[1] https://www.w3.org/TR/SMIL/smil-timing.html#q22
* Source/WebCore/svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::parseClockValue):
*
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-clock-value-out-of-range-minutes-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-clock-value-out-of-range-minutes.html:
Added.
Canonical link: https://commits.webkit.org/310184@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
