Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: aeb2eadcea86e57867cfcb4d3208628a0b15ea84
https://github.com/WebKit/WebKit/commit/aeb2eadcea86e57867cfcb4d3208628a0b15ea84
Author: Sammy Gill <[email protected]>
Date: 2026-03-30 (Mon, 30 Mar 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-size-quirks-003-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-size-quirks-003.html
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
Log Message:
-----------
Zoom.com: Copy Invitation button is difficult to click.
https://bugs.webkit.org/show_bug.cgi?id=210791
rdar://170479667
Reviewed by Alan Baradlay.
While inside a Zoom conference call, users can click an “Invite,"
button inside the participants panel, which opens up a new dialog with
an option to "Copy URL," that can be shared with others. However, it is
sometimes a bit difficult to click the button to copy the URL unless you
hover over it in the right spot. When looking at the content in the web
inspector, it looks like this is due to some other content in the DOM
that becomes too tall and protrudes into the "Copy URL," button.
This content ends up reducing into the attached test case, which is
about how percentage heights are supposed to resolve in a document that
is in quirks mode. In the reduced test case, the percentage height box is
inside of a flex item that gets flexed to take up the remaining space.
The problem is that in quirks mode, we fail to detect that this flex item
has a definite logical height that comes from the fact that its main
size, which is its logical height, has been resolved and end up skipping
it and continuing up the containing block chain in quirks mode.
RenderFlexibleBox keeps track of which part of flex layout it is in by
tracking each of the steps individually and setting them to to active
via SetForScope for a specific period of time. It then figures out which
step we are in by using this information in
canUseFlexItemForPercentageResolution
since the sizes of the flex item may become definite depending where we
are in flex layout. We can use this mechanism to decide if we can use
the flex item to resolve its descendants' percentage height.
Test:
imported/w3c/web-platform-tests/css/css-flexbox/percentage-size-quirks-003.html
Canonical link: https://commits.webkit.org/310254@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
