Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a014f760776814fbbd71f03ef9c75c74c6b45318
https://github.com/WebKit/WebKit/commit/a014f760776814fbbd71f03ef9c75c74c6b45318
Author: Ahmad Saleem <[email protected]>
Date: 2026-04-02 (Thu, 02 Apr 2026)
Changed paths:
R
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-clock-value-out-of-range-minutes-expected.txt
R
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-clock-value-out-of-range-minutes.html
A
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-clock-value-parsing-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-clock-value-parsing.html
M Source/WebCore/svg/animation/SVGSMILElement.cpp
Log Message:
-----------
Simplify fractional seconds parsing in SMIL clock values
https://bugs.webkit.org/show_bug.cgi?id=311149
rdar://173736238
Reviewed by Said Abou-Hallawa.
Simplify parseClockValue by using the result of parseNumber directly in the
calculation instead of re-parsing the substring with toDouble. Fix the seconds
boundary check to use >= 60 instead of > 59, so fractional values like 59.5
are not incorrectly rejected. Add test cases for fractional seconds
(e.g., "00:00:01.50", "00:01.50", "00:00:59.50", "00:59.50") to verify that
parseClockValue correctly preserves the fractional part. While here, this
also updates all words to plural (i.e., minute -> minutes).
Thanks Said for suggesting this.
*
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-clock-value-out-of-range-minutes-expected.txt:
Removed.
*
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-clock-value-parsing-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-clock-value-parsing.html:
Renamed from
LayoutTests/imported/w3c/web-platform-tests/svg/animations/smil-clock-value-out-of-range-minutes.html.
* Source/WebCore/svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::parseClockValue):
Canonical link: https://commits.webkit.org/310472@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
