Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 05fc1c171c0bcaee5cfbb334a588603358f088a6
https://github.com/WebKit/WebKit/commit/05fc1c171c0bcaee5cfbb334a588603358f088a6
Author: Rupin Mittal <[email protected]>
Date: 2026-04-03 (Fri, 03 Apr 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/NavigationAPI.mm
Log Message:
-----------
REGRESSION(309560@main): Newly added TestWebKitAPI.NavigationAPI.* tests
timing out
https://bugs.webkit.org/show_bug.cgi?id=311148
rdar://173733725
Reviewed by Basuke Suzuki.
I am unable to reproduce the time out locally, but I believe this is the issue:
These tests rely on using a non-persistent data store. So they explicitly set
one:
[configuration setWebsiteDataStore:[WKWebsiteDataStore nonPersistentDataStore]];
Right before they do this, they initially set up the WKWebViewConfiguration
with:
RetainPtr configuration = server.httpsProxyConfiguration();
Turns out, HTTPServer::httpsProxyConfiguration() already sets up the
WKWebViewConfiguration with a non-persistent data store. It also sets this data
store up with the the HTTPSProxy that the test needs.
So when the test explicitly sets the freshly created non-persistent data store
on
the WKWebViewConfiguration, it wipes out the data store that
httpsProxyConfiguration
added which was aware of the HTTPSProxy.
This new data store is not set up with the proxy. It likely tries to actually
go to
the network for its load instead of the proxy that is set up. The test likely
times
out if the real server for example.com does not respond in time. Perhaps it
responds
in time for me locally but not for the EWS bots.
We amend the test to use the data store set up by httpsProxyConfiguration and
not
replace it with a fresh one.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/NavigationAPI.mm:
(TestWebKitAPI::TEST(NavigationAPI,
PushStateUpdatesCurrentEntryKeyWithoutAllowPrivacySensitiveOperationsInNonPersistentDataStores)):
(TestWebKitAPI::TEST(NavigationAPI,
ReplaceStateUpdatesCurrentEntryIDWithoutAllowPrivacySensitiveOperationsInNonPersistentDataStores)):
Canonical link: https://commits.webkit.org/310530@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
