Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0d55646bbb0ea841f7539fd74ab04e051ceb0eaf
https://github.com/WebKit/WebKit/commit/0d55646bbb0ea841f7539fd74ab04e051ceb0eaf
Author: Chris Dumez <[email protected]>
Date: 2026-04-04 (Sat, 04 Apr 2026)
Changed paths:
M Source/WebCore/html/ValidatedFormListedElement.cpp
M Source/WebCore/html/ValidatedFormListedElement.h
Log Message:
-----------
m_isFocusingWithValidationMessage breaks bit packing in
ValidatedFormListedElement
https://bugs.webkit.org/show_bug.cgi?id=311416
Reviewed by Anne van Kesteren.
Every other bool member uses : 1. This one does not, breaking the bit
field packing. It forces the compiler to end the bitfield, allocate a
separate byte for this bool, then potentially pad before
`m_isInsideDataList : 2`.
Bit-fields can't bind to non-const references, so SetForScope doesn't
work with them directly. I thus had to use another pattern in
focusAndShowValidationMessage().
* Source/WebCore/html/ValidatedFormListedElement.cpp:
(WebCore::ValidatedFormListedElement::focusAndShowValidationMessage):
* Source/WebCore/html/ValidatedFormListedElement.h:
Canonical link: https://commits.webkit.org/310563@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
