Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c559ef21e24775338a1eb865f46d10d60f0bb953
https://github.com/WebKit/WebKit/commit/c559ef21e24775338a1eb865f46d10d60f0bb953
Author: David Kilzer <[email protected]>
Date: 2026-04-04 (Sat, 04 Apr 2026)
Changed paths:
M Source/WebCore/platform/PlatformMouseEvent.h
M Source/WebCore/platform/mac/PlatformEventFactoryMac.mm
M Source/WebCore/platform/win/PlatformMouseEventWin.cpp
M Source/WebKit/Shared/WebEventConversion.cpp
M Tools/TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm
Log Message:
-----------
Remove unused PlatformMouseEvent::modifierFlags() and m_modifierFlags
https://bugs.webkit.org/show_bug.cgi?id=245108
<rdar://99850228>
Reviewed by Darin Adler.
PlatformMouseEvent::modifierFlags() was last called from EventHandler to
pass raw modifier flags to Chrome::mouseDidMoveOverElement(), which was
removed in 264519@main for Bug 257175. Since then, no code reads the
field.
Modifier information is already available through the base class via
PlatformEvent::modifiers() as an OptionSet<PlatformEvent::Modifier>.
* Source/WebCore/platform/PlatformMouseEvent.h:
(WebCore::PlatformMouseEvent::modifierFlags const): Delete.
(WebCore::PlatformMouseEvent::m_modifierFlags): Delete.
* Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
* Source/WebCore/platform/win/PlatformMouseEventWin.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
* Source/WebKit/Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
- Remove unused modifierFlags() and m_modifierFlags.
* Tools/TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
(TestWebKitAPI::buildAndPerformTest):
- Replace the modifierFlags() assertion with a single EXPECT_EQ against
pme.modifiers(), using modifiersForModifierFlags() to convert the
NSEventModifierFlags parameter to an OptionSet<PlatformEvent::Modifier>.
Canonical link: https://commits.webkit.org/310567@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
