Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ecbdfc19cf68691b97a538e12baa8c0ee742ac21
https://github.com/WebKit/WebKit/commit/ecbdfc19cf68691b97a538e12baa8c0ee742ac21
Author: Alexsander Borges Damaceno <[email protected]>
Date: 2026-04-05 (Sun, 05 Apr 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/box-shadow/box-shadow-table-row-display-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/box-shadow/box-shadow-table-row-display-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/box-shadow/box-shadow-table-row-display.html
M Source/WebCore/rendering/RenderTableRow.cpp
M Source/WebCore/rendering/RenderTableRow.h
M Source/WebCore/rendering/RenderTableSection.cpp
Log Message:
-----------
`box-shadow` does not work when used on `display: table-row` elements
https://bugs.webkit.org/show_bug.cgi?id=74156
Reviewed by Simon Fraser.
`Box-shadow` was not painted correctly when applied to table-row elements
because table rows do not have a code path for paint `box-shadow` property.
This patch adds the code path for painting shadows on table rows.
Test:
imported/w3c/web-platform-tests/css/css-backgrounds/box-shadow/box-shadow-table-row-display.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/box-shadow/box-shadow-table-row-display-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/box-shadow/box-shadow-table-row-display.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/box-shadow/box-shadow-table-row-display-ref.html:
Copied from
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/box-shadow/box-shadow-table-row-display-expected.html.
* Source/WebCore/rendering/RenderTableRow.h:
* Source/WebCore/rendering/RenderTableRow.cpp:
(WebCore::RenderTableCell::paintShadowForRowIfNeeded):
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject):
Canonical link: https://commits.webkit.org/310609@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications