Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 867feab5939a8a57ea6375269d9b0590d2aa73de
https://github.com/WebKit/WebKit/commit/867feab5939a8a57ea6375269d9b0590d2aa73de
Author: Anne van Kesteren <[email protected]>
Date: 2026-04-05 (Sun, 05 Apr 2026)
Changed paths:
A
LayoutTests/fast/forms/vertical-writing-mode/select-menulist-dimensions-expected.txt
A
LayoutTests/fast/forms/vertical-writing-mode/select-menulist-dimensions.html
A LayoutTests/fast/forms/vertical-writing-mode/select-menulist-expected.html
A
LayoutTests/fast/forms/vertical-writing-mode/select-menulist-sideways-lr-expected.html
A
LayoutTests/fast/forms/vertical-writing-mode/select-menulist-sideways-lr.html
A
LayoutTests/fast/forms/vertical-writing-mode/select-menulist-vertical-variants-expected.html
A
LayoutTests/fast/forms/vertical-writing-mode/select-menulist-vertical-variants.html
A LayoutTests/fast/forms/vertical-writing-mode/select-menulist.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/mac-sequoia/TestExpectations
M Source/WebCore/platform/graphics/mac/controls/MenuListButtonMac.mm
M Source/WebCore/rendering/RenderMenuList.cpp
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/RenderTheme.h
M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp
M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.h
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm
M Source/WebCore/rendering/ios/RenderThemeIOS.h
M Source/WebCore/rendering/ios/RenderThemeIOS.mm
M Source/WebCore/rendering/mac/RenderThemeMac.h
M Source/WebCore/rendering/mac/RenderThemeMac.mm
Log Message:
-----------
REGRESSION (306393@main): <select> control vertical writing mode is broken
https://bugs.webkit.org/show_bug.cgi?id=311522
rdar://174068353
Reviewed by Darin Adler.
Before each caller of popupInternalPaddingBox() had to do adjustments.
We now make it so that calling popupInternalPaddingBox() always gives
you the logical padding box.
This also ends up adding support for sideways-lr, which was not working
before the regression.
In addition we improve the code for positioning the "chevron" glyph as
it wasn't correctly centered in vertical writing modes before the
regression. We also fix this in the pre-26 code paths.
We also add test coverage so this is less likely to happen again in a
future refactoring.
Unfortunately Linux platforms don't fully support vertical writing
mode for <select>. And we skip select-menulist.html pre-26 on macOS
because NSPopUpButtonCell ends up rendering vertical <select>
differently from a transformed <select> (border is light vs dark).
Tests: fast/forms/vertical-writing-mode/select-menulist-dimensions.html
fast/forms/vertical-writing-mode/select-menulist-sideways-lr.html
fast/forms/vertical-writing-mode/select-menulist-vertical-variants.html
fast/forms/vertical-writing-mode/select-menulist.html
Canonical link: https://commits.webkit.org/310622@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
