Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9971986dcebbc9ad5713a058e7951288c455bbee
https://github.com/WebKit/WebKit/commit/9971986dcebbc9ad5713a058e7951288c455bbee
Author: Antti Koivisto <[email protected]>
Date: 2026-04-08 (Wed, 08 Apr 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/dashed-function-cycles-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/dashed-function-eval-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/function-conditionals-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/function-shadow-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/local-attr-substitution-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/local-if-substitution-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/local-var-substitution-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/parameter-types.tentative-expected.txt
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Syntax.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Syntax.h
M Source/WebCore/style/StyleBuilder.cpp
M Source/WebCore/style/StyleBuilder.h
M Source/WebCore/style/StyleCustomPropertyRegistry.cpp
M Source/WebCore/style/StyleSubstitutionContext.h
M Source/WebCore/style/StyleSubstitutionResolver.cpp
Log Message:
-----------
[css-mixins-1] Evaluate function arguments
https://bugs.webkit.org/show_bug.cgi?id=311558
rdar://174150107
Reviewed by Sam Weinig.
https://drafts.csswg.org/css-mixins/#evaluating-custom-functions
Basic support for evaluating functions with arguments.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/dashed-function-cycles-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/dashed-function-eval-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/function-conditionals-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/function-shadow-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/local-attr-substitution-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/local-if-substitution-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/local-var-substitution-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/parameter-types.tentative-expected.txt:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Syntax.cpp:
(WebCore::CSSPropertyParserHelpers::consumeFunctionResult):
Name the custom property value in the result descriptor `result`.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Syntax.h:
* Source/WebCore/style/StyleBuilder.cpp:
(WebCore::Style::Builder::resolveFunctionResult):
Helper for evaluating function using a nested builder.
* Source/WebCore/style/StyleBuilder.h:
* Source/WebCore/style/StyleSubstitutionContext.h:
Add "Function" context type.
* Source/WebCore/style/StyleSubstitutionResolver.cpp:
(WebCore::Style::SubstitutionResolver::substituteDashedFunction):
Parse the parameters and match them with the provided arguments.
Initialize the resulting name/value pairs as custom propertie to a style and
resolve the `result` descriptor using a nested style builder.
Canonical link: https://commits.webkit.org/310768@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
