Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a38e55c83134ff3099a27026c925f9decb86b7fd
https://github.com/WebKit/WebKit/commit/a38e55c83134ff3099a27026c925f9decb86b7fd
Author: Anne van Kesteren <[email protected]>
Date: 2026-04-08 (Wed, 08 Apr 2026)
Changed paths:
M
LayoutTests/fast/forms/vertical-writing-mode/select-menulist-dimensions-expected.txt
M
LayoutTests/fast/forms/vertical-writing-mode/select-menulist-dimensions.html
A
LayoutTests/fast/forms/vertical-writing-mode/select-menulist-rtl-expected.html
A LayoutTests/fast/forms/vertical-writing-mode/select-menulist-rtl.html
M
LayoutTests/fast/forms/vertical-writing-mode/select-menulist-vertical-variants.html
M LayoutTests/fast/forms/vertical-writing-mode/select-menulist.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/mac-sequoia/TestExpectations
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp
M Source/WebCore/rendering/ios/RenderThemeIOS.mm
M Source/WebCore/rendering/mac/RenderThemeMac.mm
Log Message:
-----------
Manage <select> RTL padding logic in popupInternalPaddingBox() as well
https://bugs.webkit.org/show_bug.cgi?id=311564
Reviewed by Elika Etemad and Darin Adler.
310622@main made it so we handle vertical logic in a central place, but
RTL was still embedded in the platform code, which was a bit confusing.
We also used computedWritingMode() which isn't idiomatic.
We also add some test coverage for RTL.
Test: fast/forms/vertical-writing-mode/select-menulist-rtl.html
Canonical link: https://commits.webkit.org/310786@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
