Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8203ea8bcc856d8989dddfa20f968a54fdb9b953
https://github.com/WebKit/WebKit/commit/8203ea8bcc856d8989dddfa20f968a54fdb9b953
Author: Tyler Wilcock <[email protected]>
Date: 2026-04-08 (Wed, 08 Apr 2026)
Changed paths:
M LayoutTests/accessibility-isolated-tree/TestExpectations
M LayoutTests/accessibility/image-link-expected.txt
M LayoutTests/accessibility/image-map2-expected.txt
M LayoutTests/accessibility/image-map2.html
M LayoutTests/accessibility/mac/document-links-expected.txt
M LayoutTests/accessibility/mac/document-links.html
M LayoutTests/accessibility/mac/element-paths-expected.txt
M LayoutTests/accessibility/mac/element-paths.html
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXGeometryManager.cpp
M Source/WebCore/accessibility/AXGeometryManager.h
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.h
M Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
Log Message:
-----------
AX: Keep element paths up-to-date as the viewport changes, and expand path
support to border-radius and clip-path
https://bugs.webkit.org/show_bug.cgi?id=311699
rdar://174283494
Reviewed by Joshua Hoffman.
Previously, element paths were stored as an AXProperty::Path on each
AXIsolatedObject, snapshotted once at tree-build time. This made them
stale when elements or the viewport moved.
This patch removes AXProperty::Path from the isolated tree entirely and
instead caches paths in AXGeometryManager during paint, alongside the
existing rect cache. AXIsolatedObject::elementPath() now reads from
this cache on-demand. This lays groundwork for a follow-up that adds
on-demand path computation for multi-line text and links.
* LayoutTests/accessibility-isolated-tree/TestExpectations:
New test fails because we don't get paint callbacks for certain SVG types,
meaning
we can't cache a path for them.
* LayoutTests/accessibility/image-link-expected.txt:
* LayoutTests/accessibility/image-map2-expected.txt:
* LayoutTests/accessibility/image-map2.html:
* LayoutTests/accessibility/mac/document-links-expected.txt:
* LayoutTests/accessibility/mac/document-links.html:
* LayoutTests/accessibility/mac/element-paths-expected.txt:
* LayoutTests/accessibility/mac/element-paths.html:
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::supportsPath const):
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::AXCoreObject::isStaticTextLabel const):
* Source/WebCore/accessibility/AXGeometryManager.cpp:
(WebCore::AXGeometryManager::cachePathForID):
(WebCore::AXGeometryManager::cachedPathForID):
(WebCore::AXGeometryManager::remove):
* Source/WebCore/accessibility/AXGeometryManager.h:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::onPaint const):
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::supportsPath const):
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::computePathForRenderBox):
(WebCore::AccessibilityRenderObject::elementPath const):
(WebCore::AccessibilityRenderObject::supportsPath const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.h:
* Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm:
(WebCore::AXCoreObject::rolePlatformString):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::isDefaultValue):
(WebCore::AXIsolatedObject::supportsPath const):
(WebCore::AXIsolatedObject::elementPath const):
(WebCore::AXIsolatedObject::pathAttributeValue const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::createIsolatedObjectData):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
Canonical link: https://commits.webkit.org/310796@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
