Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0480ede811e031853bb8b7f5e759ff014bebc564
      
https://github.com/WebKit/WebKit/commit/0480ede811e031853bb8b7f5e759ff014bebc564
  Author: Kimmo Kinnunen <[email protected]>
  Date:   2026-04-09 (Thu, 09 Apr 2026)

  Changed paths:
    M Source/ThirdParty/ANGLE/src/tests/perf_tests/ANGLEPerfTest.cpp
    M Source/ThirdParty/ANGLE/src/tests/test_utils/ANGLETest.cpp
    M Source/ThirdParty/ANGLE/src/tests/test_utils/ANGLETestCL.cpp
    M Source/ThirdParty/ANGLE/src/tests/test_utils/angle_test_instantiate.cpp
    M Source/ThirdParty/ANGLE/src/tests/test_utils/angle_test_instantiate.h
    M Source/ThirdParty/ANGLE/src/tests/test_utils/runner/README.md
    M Source/ThirdParty/ANGLE/src/tests/test_utils/runner/TestSuite.cpp
    M Source/ThirdParty/ANGLE/src/tests/test_utils/runner/TestSuite.h

  Log Message:
  -----------
  ANGLE: Metal: Run unit tests with validation layers by default
https://bugs.webkit.org/show_bug.cgi?id=311724
rdar://174311180

Reviewed by Mike Wyrzykowski.

Add test runner flag --disable-debug-layers to disable the layers,
since the layers change the output in some cases.

Metal debug layers are global and the environment variable must be
set before Metal framework is used. IsMetalRendererAvailable()
and EGLContextCompatibilityTest create Metal devices before command
line is parsed, so force debug layers on at the runner level
instead of the test level.

For consistency, handle --disable-debug-layers for other platforms too.

* Source/ThirdParty/ANGLE/src/tests/perf_tests/ANGLEPerfTest.cpp:
(RenderTestParams::RenderTestParams):
* Source/ThirdParty/ANGLE/src/tests/test_utils/ANGLETest.cpp:
(ANGLETestBase::ANGLETestBase):
* Source/ThirdParty/ANGLE/src/tests/test_utils/ANGLETestCL.cpp:
(ANGLETestCL<PlatformParameters>::ANGLETestCL):
* Source/ThirdParty/ANGLE/src/tests/test_utils/angle_test_instantiate.cpp:
* Source/ThirdParty/ANGLE/src/tests/test_utils/angle_test_instantiate.h:
* Source/ThirdParty/ANGLE/src/tests/test_utils/runner/README.md:
* Source/ThirdParty/ANGLE/src/tests/test_utils/runner/TestSuite.cpp:
(angle::TestSuite::TestSuite):
(angle::TestSuite::parseSingleArg):
* Source/ThirdParty/ANGLE/src/tests/test_utils/runner/TestSuite.h:

Canonical link: https://commits.webkit.org/310832@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to