Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f647d7feb5649d42014b43f707fd4a92c92d28da
https://github.com/WebKit/WebKit/commit/f647d7feb5649d42014b43f707fd4a92c92d28da
Author: Keith Miller <[email protected]>
Date: 2026-04-13 (Mon, 13 Apr 2026)
Changed paths:
M Makefile.shared
M Tools/Scripts/webkitdirs.pm
Log Message:
-----------
set-webkit-configuration should properly support the non-standard
testing/release+assert builds
https://bugs.webkit.org/show_bug.cgi?id=311824
rdar://174414568
Reviewed by Elliott Williams.
WIP
Right now when passing `--ra` or `--testing` to `set-webkit-configuration`
it silently sets the configuration to the wrong values so tools think
the product directory is WebKitBuild/Release+Assert or
WebKitBuild/Testing, which is not where things end up. This patch moves
the current `Makefile.shared` logic into `webkitdirs.pm`
This should also make `--ra`/`--testing` "sticky" like `--debug` and
`--release` are today.
* Makefile.shared:
* Tools/Scripts/webkitdirs.pm:
(determineConfigurationForVisualStudio):
(determineConfigurationProductDir):
(baseConfiguration):
(XcodeOptions):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):
(cleanCMakeGeneratedProject):
Canonical link: https://commits.webkit.org/311091@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
