Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a8a3e445d53b440be0636a7858fa70f34835baf1
https://github.com/WebKit/WebKit/commit/a8a3e445d53b440be0636a7858fa70f34835baf1
Author: Richard Robinson <[email protected]>
Date: 2026-04-13 (Mon, 13 Apr 2026)
Changed paths:
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
M
Tools/TestWebKitAPI/Tests/WebKit/WKWebView/CloseWebViewAfterEnterFullscreen.mm
Log Message:
-----------
CloseWebViewAfterEnterFullscreen API tests may sometimes timeout
https://bugs.webkit.org/show_bug.cgi?id=312230
rdar://174708985
Reviewed by Jer Noble.
These tests were not waiting for full screen to exit. Fix by modifying the
tests to do so, and also
fix an underlying issue where the delegate callback was not getting called in
the first place since
the normal IPC round-trip through the web process won't complete after the page
is closed.
Test:
Tools/TestWebKitAPI/Tests/WebKit/WKWebView/CloseWebViewAfterEnterFullscreen.mm
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::detachFromClient):
*
Tools/TestWebKitAPI/Tests/WebKit/WKWebView/CloseWebViewAfterEnterFullscreen.mm:
(TestWebKitAPI::TEST(CloseWebViewAfterEnterFullscreen, VideoFullscreen)):
(TestWebKitAPI::TEST(CloseWebViewAfterEnterFullscreen, ElementFullscreen)):
Canonical link: https://commits.webkit.org/311176@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
