Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c39cccad9e0ccf80cb65f2b3dbfad5342a1fd9dd
      
https://github.com/WebKit/WebKit/commit/c39cccad9e0ccf80cb65f2b3dbfad5342a1fd9dd
  Author: Sergio Villar Senin <[email protected]>
  Date:   2026-04-15 (Wed, 15 Apr 2026)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-005-expected.txt
    M Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp
    M Tools/TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp

  Log Message:
  -----------
  Identity matrix decomposition generates invalid quaternions
https://bugs.webkit.org/show_bug.cgi?id=312260

Reviewed by Antoine Quint.

Identity matrix decomposition was generating invalid quaternions of the
form (0, 0, 0, 0). The w component must be 1 to be a valid quaternion
that still represents no rotation.

As a nice side effect this fixes a bunch of CSS transform subtests. We
are adding a unit test just in case.

Test: Tools/TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-005-expected.txt:
* Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::decompose4 const):
* Tools/TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
(TestWebKitAPI::TEST(TransformationMatrix, IdentityDecomposition)):

Canonical link: https://commits.webkit.org/311267@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to