Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2ced66fc20ca3b3aaafa158d783e9d7f560ba7d8
https://github.com/WebKit/WebKit/commit/2ced66fc20ca3b3aaafa158d783e9d7f560ba7d8
Author: Yulun Wu <[email protected]>
Date: 2026-04-15 (Wed, 15 Apr 2026)
Changed paths:
M Source/WebCore/layout/integration/LayoutIntegrationBoxTreeUpdater.cpp
Log Message:
-----------
[Refactor] updateListMarkerAttributes to calculateListMarkerAttributes in
LayoutIntegrationBoxTreeUpdater
https://bugs.webkit.org/show_bug.cgi?id=312306
<rdar://173664868>
Reviewed by Said Abou-Hallawa.
This PR replaces updateListMarkerAttributes(), which mutates a
Layout::ElementBox
in place, with calculateListMarkerAttribute(), which returns the computed
attributes. This allows list marker attributes to be passed directly into the
ElementBox constructor instead of creating the object then immediately mutating
it.
Other consumers now explicitly call setListMarkerAttributes() with the result
of calculateListMarkerAttribute().
* Source/WebCore/layout/integration/LayoutIntegrationBoxTreeUpdater.cpp:
(WebCore::LayoutIntegration::calculateListMarkerAttribute):
(WebCore::LayoutIntegration::BoxTreeUpdater::createLayoutBox):
(WebCore::LayoutIntegration::BoxTreeUpdater::updateStyle):
(WebCore::LayoutIntegration::updateListMarkerAttributes): Deleted.
Canonical link: https://commits.webkit.org/311316@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
