Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 561b0719d80db5f9e66400463c65a588c9c31208
https://github.com/WebKit/WebKit/commit/561b0719d80db5f9e66400463c65a588c9c31208
Author: Ryosuke Niwa <[email protected]>
Date: 2026-04-16 (Thu, 16 Apr 2026)
Changed paths:
A
LayoutTests/fast/dom/MutationObserver/mutation-record-child-list-disconnected-root-expected.txt
A
LayoutTests/fast/dom/MutationObserver/mutation-record-child-list-disconnected-root.html
A LayoutTests/fast/dom/node-iterator-disconnected-root-expected.txt
A LayoutTests/fast/dom/node-iterator-disconnected-root.html
A LayoutTests/fast/dom/tree-walker-disconnected-root-expected.txt
A LayoutTests/fast/dom/tree-walker-disconnected-root.html
M Source/WebCore/bindings/js/JSNodeIteratorCustom.cpp
M Source/WebCore/bindings/js/JSTreeWalkerCustom.cpp
M Source/WebCore/dom/MutationRecord.cpp
Log Message:
-----------
Fix GC correctness bugs with NodeIterator, TreeWalker, and MutationRecord
https://bugs.webkit.org/show_bug.cgi?id=312435
Reviewed by Chris Dumez.
Fix the bugs that these classes weren't keeping JS wrappers of some of their
Node properties alive
by adding them in visitAdditionalChildren.
Tests:
fast/dom/MutationObserver/mutation-record-child-list-disconnected-root.html
fast/dom/node-iterator-disconnected-root.html
fast/dom/tree-walker-disconnected-root.html
*
LayoutTests/fast/dom/MutationObserver/mutation-record-child-list-disconnected-root-expected.txt:
Added.
*
LayoutTests/fast/dom/MutationObserver/mutation-record-child-list-disconnected-root.html:
Added.
* LayoutTests/fast/dom/node-iterator-disconnected-root-expected.txt: Added.
* LayoutTests/fast/dom/node-iterator-disconnected-root.html: Added.
* LayoutTests/fast/dom/tree-walker-disconnected-root-expected.txt: Added.
* LayoutTests/fast/dom/tree-walker-disconnected-root.html: Added.
* Source/WebCore/bindings/js/JSNodeIteratorCustom.cpp:
(WebCore::JSNodeIterator::visitAdditionalChildrenInGCThread):
* Source/WebCore/bindings/js/JSTreeWalkerCustom.cpp:
(WebCore::JSTreeWalker::visitAdditionalChildrenInGCThread):
* Source/WebCore/dom/MutationRecord.cpp:
(WebCore::ChildListRecord::visitNodesInGCThread):
Canonical link: https://commits.webkit.org/311355@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
