Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cbc659b870a79cf6317b59fc508e8ad62e364d40
https://github.com/WebKit/WebKit/commit/cbc659b870a79cf6317b59fc508e8ad62e364d40
Author: Diego De La Toba <[email protected]>
Date: 2026-04-16 (Thu, 16 Apr 2026)
Changed paths:
M LayoutTests/inspector/runtime/execution-context-in-scriptless-page.html
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebInspectorUI/UserInterface/Models/Frame.js
M Source/WebInspectorUI/UserInterface/Protocol/FrameTarget.js
Log Message:
-----------
[macOS release] inspector/runtime/execution-context-in-scriptless-page.html
is a flaky text failure.
rdar://174512679
https://bugs.webkit.org/show_bug.cgi?id=311958
Reviewed by Qianlang Chen and BJ Burg.
This test flakily times out on macOS release because
awaitEvent(ExecutionContextAdded)
can miss the event and the execution context may already exist on the target by
the time
the listener is registered after TargetAdded resolves, causing an indefinite
wait.
Files changed (3):
1. Frame.js - Added ensurePageExecutionContext() that ensures context has
been or was
already added to page. Adjusted clearExecutionContexts() to reset context
promise.
2. TargetFrame.js - Added ensureTargetExecutionContext that ensures context
has been
or was already added to target. Adjusted clearExecutionContexts() to reset
context promise.
3. execution-context-in-scriptless-page.html - instead of doing a forward
await on
context both codepaths now use dedicated helpers to verify context exists.
* LayoutTests/inspector/runtime/execution-context-in-scriptless-page.html:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebInspectorUI/UserInterface/Models/Frame.js:
(WI.Frame.prototype.clearExecutionContexts):
(WI.Frame.prototype.ensurePageExecutionContext):
* Source/WebInspectorUI/UserInterface/Protocol/FrameTarget.js:
(WI.FrameTarget.prototype.ensureTargetExecutionContext):
(WI.FrameTarget.prototype.clearExecutionContexts):
(WI.FrameTarget):
Canonical link: https://commits.webkit.org/311360@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
