Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 70c3f51ed35e6115022c005717b90a2f03942833
https://github.com/WebKit/WebKit/commit/70c3f51ed35e6115022c005717b90a2f03942833
Author: Ruthvik Konda <[email protected]>
Date: 2026-04-16 (Thu, 16 Apr 2026)
Changed paths:
M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
M Source/WebKit/WebProcess/Model/WebModelPlayer.mm
Log Message:
-----------
Use protect() instead of RefPtr { } in model element code
https://bugs.webkit.org/show_bug.cgi?id=312454
rdar://174902323
Reviewed by Anne van Kesteren and Mike Wyrzykowski.
Mechanical migration from RefPtr { expr } to protect(expr) across model
element code, aligning with the codebase-wide transition away from
brace-initialized smart pointer temporaries.
For HTMLModelElement::deleteModelPlayer, m_modelPlayerProvider is a WeakPtr
so protect(m_modelPlayerProvider) uses the WeakPtr-to-RefPtr overload
directly, which is cleaner than the previous RefPtr { .get() } pattern.
No new tests needed (no behavioral change, style-only refactor).
* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::deleteModelPlayer):
(WebCore::HTMLModelElement::getOrCreateModelPlayer):
* Source/WebKit/WebProcess/Model/WebModelPlayer.mm:
(WebKit::WebModelPlayer::sizeDidChange):
(WebKit::WebModelPlayer::render):
Canonical link: https://commits.webkit.org/311386@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications