Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7090b7dbbf8fb4cbd234a620d41f9c69a88b3d0c
https://github.com/WebKit/WebKit/commit/7090b7dbbf8fb4cbd234a620d41f9c69a88b3d0c
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2026-04-16 (Thu, 16 Apr 2026)
Changed paths:
M Source/WebCore/dom/MouseEventTypes.h
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/platform/PlatformMouseEvent.h
M Source/WebKit/Shared/NativeWebMouseEvent.h
M Source/WebKit/Shared/WebEvent.serialization.in
M Source/WebKit/Shared/WebEventConversion.cpp
M Source/WebKit/Shared/WebMouseEvent.cpp
M Source/WebKit/Shared/WebMouseEvent.h
M Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp
M Source/WebKit/Shared/ios/NativeWebMouseEventIOS.mm
M Source/WebKit/Shared/libwpe/WebEventFactory.cpp
M Source/WebKit/Shared/mac/NativeWebMouseEventMac.mm
M Source/WebKit/Shared/mac/WebEventFactory.h
M Source/WebKit/Shared/mac/WebEventFactory.mm
M Source/WebKit/Shared/wpe/WebEventFactoryWPE.cpp
M Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
Log Message:
-----------
[AppKit Gestures] Press gesture-based mouse tracking loop should not initiate
drag
https://bugs.webkit.org/show_bug.cgi?id=312410
rdar://174863440
Reviewed by Richard Robinson and Aditya Keerthi.
We will eventually figure out a solution to support dragging, but in
the meantime, this teaches EventHandler to not initiate drags from the
press gesture recognizer we use to do mouse tracking.
In service of this behavior, we need to plumb metadata through mouse
events about which instances can actually initiate a drag.
* Source/WebCore/dom/MouseEventTypes.h:
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
* Source/WebCore/platform/PlatformMouseEvent.h:
(WebCore::PlatformMouseEvent::canInitiateDrag const):
* Source/WebKit/Shared/NativeWebMouseEvent.h:
* Source/WebKit/Shared/WebEvent.serialization.in:
* Source/WebKit/Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
* Source/WebKit/Shared/WebMouseEvent.cpp:
(WebKit::WebMouseEvent::WebMouseEvent):
* Source/WebKit/Shared/WebMouseEvent.h:
(WebKit::WebMouseEvent::WebMouseEvent):
(WebKit::WebMouseEvent::canInitiateDrag const):
* Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp:
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
* Source/WebKit/Shared/ios/NativeWebMouseEventIOS.mm:
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
* Source/WebKit/Shared/libwpe/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebMouseEvent):
* Source/WebKit/Shared/mac/NativeWebMouseEventMac.mm:
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
* Source/WebKit/Shared/mac/WebEventFactory.h:
* Source/WebKit/Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebMouseEvent):
* Source/WebKit/Shared/wpe/WebEventFactoryWPE.cpp:
(WebKit::WebEventFactory::createWebMouseEvent):
* Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm:
(-[WKAppKitGestureController mouseTrackingGestureRecognized:]):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::nativeMouseEventHandler):
(WebKit::WebViewImpl::nativeMouseEventHandlerInternal):
(WebKit::WebViewImpl::mouseDownInternal):
(WebKit::WebViewImpl::mouseUpInternal):
(WebKit::WebViewImpl::mouseDraggedInternal):
(WebKit::WebViewImpl::mouseDown):
(WebKit::WebViewImpl::mouseUp):
(WebKit::WebViewImpl::mouseDragged):
Canonical link: https://commits.webkit.org/311392@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
