Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 659c76126a285b0608a5c511ffe1ec232aafb446
https://github.com/WebKit/WebKit/commit/659c76126a285b0608a5c511ffe1ec232aafb446
Author: Kimmo Kinnunen <[email protected]>
Date: 2026-04-16 (Thu, 16 Apr 2026)
Changed paths:
M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
M Source/ThirdParty/ANGLE/src/tests/angle_deqp_tests_main.cpp
M Source/ThirdParty/ANGLE/src/tests/angle_end2end_tests_main.cpp
M Source/ThirdParty/ANGLE/src/tests/angle_unittest_main.cpp
M Source/ThirdParty/ANGLE/src/tests/gl_tests/ContextLostTest.cpp
M Source/ThirdParty/ANGLE/src/tests/test_utils/ANGLETest.cpp
M Source/ThirdParty/ANGLE/src/tests/test_utils/runner/TestSuite.cpp
M Source/ThirdParty/ANGLE/src/tests/test_utils/runner/TestSuite.h
M Source/ThirdParty/ANGLE/util/OSWindow.cpp
M Source/ThirdParty/gtest/xcode/gtest.xcodeproj/project.pbxproj
Log Message:
-----------
ANGLE: Enable ANGLE test expectations in ANGLEEnd2EndTests runner
https://bugs.webkit.org/show_bug.cgi?id=311647
rdar://174233237
Reviewed by Elliott Williams and Mike Wyrzykowski.
ANGLEEnd2EndTests test runner would run all the tests in normal gtest
mode. Upstream ANGLE has further result lists in angle_end2end_tests.txt
test expectations. Without the expectations, the full clean test runs
are hard to run since the skips are not applied and few test suites
cause crashes.
Compile the full upstraem test result functionality from TestSuite.cpp.
The complication was that TestSuite.cpp depends on RapidJSON which
we do not want to import unless explicitly needed. Use ifdefs to
further carve out RapidJSON use. Currently in upstream it is used in
"bot" mode to report subprocess results to main test runner process and
to export the bot results.
Disable incompatible test runner code with existing
!ANGLE_OUTSIDE_WEBKIT define. This mainly disables the feature upstream
uses to disable Metal shader cache to speed up the test runs. We do not
compile the dylib used to do this, and instead should improve Metal
until the runs are fast enough.
GTest changes:
Change the gtest exported headers to export one implementation header:
gtest/src/gtest-internal-inl.h. This is used to evaluate the gtest
filter pattern against the test list compiled from the test
expectations file.
Previously the project file would mark headers exported and have a
copy rule to copy *.h files to framework export headers path.
The change here adds a pattern */include/**/*.h to this rule.
The change here also adds a pattern */src/*.h to copy the
implementation private header to gtest/src/.
* Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj:
* Source/ThirdParty/ANGLE/src/tests/angle_deqp_tests_main.cpp:
(main):
* Source/ThirdParty/ANGLE/src/tests/angle_end2end_tests_main.cpp:
(main):
* Source/ThirdParty/ANGLE/src/tests/angle_unittest_main.cpp:
(main):
* Source/ThirdParty/ANGLE/src/tests/gl_tests/ContextLostTest.cpp:
* Source/ThirdParty/ANGLE/src/tests/test_utils/ANGLETest.cpp:
(ANGLETestBase::ANGLETestSetUp):
* Source/ThirdParty/ANGLE/src/tests/test_utils/runner/TestSuite.cpp:
(angle::TestSuite::TestSuite):
* Source/ThirdParty/ANGLE/src/tests/test_utils/runner/TestSuite.h:
* Source/ThirdParty/ANGLE/util/OSWindow.cpp:
(angle::FindTestDataPath):
* Source/ThirdParty/gtest/xcode/gtest.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/311423@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
