Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9835f97a12015b31a58358dfc1773e974ed6103d
https://github.com/WebKit/WebKit/commit/9835f97a12015b31a58358dfc1773e974ed6103d
Author: Cole Carley <[email protected]>
Date: 2026-04-17 (Fri, 17 Apr 2026)
Changed paths:
M Tools/MiniBrowser/mac/SettingsController.h
M Tools/MiniBrowser/mac/SettingsController.m
M Tools/MiniBrowser/mac/WK2BrowserWindowController.m
Log Message:
-----------
Use findDelegate in mac MiniBrowser
rdar://174960802
https://bugs.webkit.org/show_bug.cgi?id=312518
Reviewed by Megan Gardner.
Mac's MiniBrowser implementation does Find in Page differently
than Safari, which means that every time changes are made to the
find code on the WebKit side, Safari has to be built to manually
test the changes.
I have added an option to MiniBrowser's settings called "Use Find Delegate."
This is on by default, and changes the find implementation to be similar to
Safari's. The workload is similar and the API calls are the same, so MiniBrowser
can be used to test Find in Page.
You can uncheck "Use Find Delegate" to use the old TextFinder implementation.
* Tools/MiniBrowser/mac/SettingsController.h:
* Tools/MiniBrowser/mac/SettingsController.m:
(-[SettingsController initWithMenu:]):
(-[SettingsController _populateMenu:]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController toggleUseFindDelegate:]):
(-[SettingsController useFindDelegate]):
* Tools/MiniBrowser/mac/WK2BrowserWindowController.m:
(-[FindBarFieldEditor performTextFinderAction:]):
(-[FindBarFieldEditor validateMenuItem:]):
(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController windowWillReturnFieldEditor:toObject:]):
(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController _shouldUseFindDelegate]):
(-[WK2BrowserWindowController _ensureFindDelegateSetup]):
(-[WK2BrowserWindowController _ensureTextFinderSetup]):
(-[WK2BrowserWindowController _buildFindBar]):
(-[WK2BrowserWindowController _showFindBar]):
(-[WK2BrowserWindowController _hideFindBarAndUI]):
(-[WK2BrowserWindowController _findStringInDirection:]):
(-[WK2BrowserWindowController performTextFinderAction:]):
(-[WK2BrowserWindowController _findNext:]):
(-[WK2BrowserWindowController _findPrevious:]):
(-[WK2BrowserWindowController _hideFindBar:]):
(-[WK2BrowserWindowController cancelOperation:]):
(-[WK2BrowserWindowController control:textView:doCommandBySelector:]):
(-[WK2BrowserWindowController controlTextDidChange:]):
(-[WK2BrowserWindowController _updateDisplayedMatchCount:matchIndex:]):
(-[WK2BrowserWindowController _webView:didCountMatches:forString:]):
(-[WK2BrowserWindowController
_webView:didFindMatches:forString:withMatchIndex:]):
(-[WK2BrowserWindowController _webView:didFailToFindString:]):
(-[WK2BrowserWindowController setFindBarView:]):
* default.profraw: Added.
Canonical link: https://commits.webkit.org/311498@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
