Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cd1fe08a65fa708ada170c25c607ea43a324139b
https://github.com/WebKit/WebKit/commit/cd1fe08a65fa708ada170c25c607ea43a324139b
Author: Andy Estes <[email protected]>
Date: 2026-04-17 (Fri, 17 Apr 2026)
Changed paths:
M Source/WebCore/platform/graphics/MediaPlaybackTarget.h
M Source/WebCore/platform/graphics/MediaPlaybackTargetWirelessPlayback.cpp
M Source/WebCore/platform/graphics/MediaPlaybackTargetWirelessPlayback.h
M Source/WebCore/platform/graphics/MediaPlayerPrivateWirelessPlayback.cpp
Log Message:
-----------
[iOS] MediaDeviceRoute::loadURL is called multiple times during loading by
MediaPlayerPrivateWirelessPlayback
https://bugs.webkit.org/show_bug.cgi?id=312442
rdar://174891787
Reviewed by Jer Noble.
MediaPlayerPrivateWirelessPlayback::setWirelessPlaybackTarget may be called
more than once with
MediaPlaybackTargets that have different addresses but share a common
MediaDeviceRoute. When this
happens, we don't want to ask the MediaDeviceRoute to load a URL again (since
we already asked it
to the first time). Addressed this by returning early in
MediaPlayerPrivateWirelessPlayback::setWirelessPlaybackTarget when both the old
and new
MediaPlaybackTargets are MediaPlaybackTargetWirelessPlaybacks and have equal
identifiers.
Tested manually. It's currently not possible to test this exact case in a
layout test since in that
configuration MediaPlayerPrivateWirelessPlayback is instantiated in the
WebContent process where
there is always exactly one MediaPlaybackTargetWirelessPlayback for a given
MediaDeviceRoute.
* Source/WebCore/platform/graphics/MediaPlaybackTarget.h:
(WebCore::MediaPlaybackTarget::operator== const):
* Source/WebCore/platform/graphics/MediaPlaybackTargetWirelessPlayback.cpp:
(WebCore::MediaPlaybackTargetWirelessPlayback::operator== const):
* Source/WebCore/platform/graphics/MediaPlaybackTargetWirelessPlayback.h:
* Source/WebCore/platform/graphics/MediaPlayerPrivateWirelessPlayback.cpp:
(WebCore::MediaPlayerPrivateWirelessPlayback::setWirelessPlaybackTarget):
Canonical link: https://commits.webkit.org/311501@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
