Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 816e63a20c18a2fca81e619292eaf7385420c226
https://github.com/WebKit/WebKit/commit/816e63a20c18a2fca81e619292eaf7385420c226
Author: Ruthvik Konda <[email protected]>
Date: 2026-04-17 (Fri, 17 Apr 2026)
Changed paths:
A
LayoutTests/webanimations/threaded-animations/animation-suspension-no-timelines-controller-crash-expected.txt
A
LayoutTests/webanimations/threaded-animations/animation-suspension-no-timelines-controller-crash.html
M Source/WebCore/animation/KeyframeEffect.cpp
Log Message:
-----------
[threaded-animations] Null timelinesController crash in
scheduleAssociatedAcceleratedEffectStackUpdate during animation suspension
https://bugs.webkit.org/show_bug.cgi?id=312595
rdar://173391422
Reviewed by Antoine Quint.
scheduleAssociatedAcceleratedEffectStackUpdate() assumes
document()->timelinesController()
is non-null, but it can be null when the effect's document never had a
DocumentTimeline
created. This can happen when elements move between documents while
ThreadedTimeBasedAnimationsEnabled is on and alert() triggers animation
suspension via
PageGroupLoadDeferrer.
Replace the ASSERT with a null check and early return, matching the convention
used by
all other callers of timelinesController() in Page.cpp and LocalFrame.cpp.
Test:
webanimations/threaded-animations/animation-suspension-no-timelines-controller-crash.html
*
LayoutTests/webanimations/threaded-animations/animation-suspension-no-timelines-controller-crash-expected.txt:
Added.
*
LayoutTests/webanimations/threaded-animations/animation-suspension-no-timelines-controller-crash.html:
Added.
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::scheduleAssociatedAcceleratedEffectStackUpdate):
Canonical link: https://commits.webkit.org/311510@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
