Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d3b687ec2dc96a63e9675dabbd592c27b3c32657
https://github.com/WebKit/WebKit/commit/d3b687ec2dc96a63e9675dabbd592c27b3c32657
Author: Mike Wyrzykowski <[email protected]>
Date: 2026-04-21 (Tue, 21 Apr 2026)
Changed paths:
M Source/WebKit/GPUProcess/graphics/Model/ModelBridge.swift
M Source/WebKit/GPUProcess/graphics/Model/ModelRenderer.swift
M Source/WebKit/GPUProcess/graphics/Model/ModelTypes.h
M Source/WebKit/GPUProcess/graphics/Model/ModelUtils.swift
M Source/WebKit/GPUProcess/graphics/Model/USDModel.swift
M Source/WebKit/GPUProcess/graphics/Model/WebKitMesh.mm
M Source/WebKit/Shared/Model.serialization.in
M Source/WebKit/WebProcess/Model/ModelInlineConverters.h
Log Message:
-----------
ShaderGraph does not get correctly reconstructed after passed over IPC
https://bugs.webkit.org/show_bug.cgi?id=311830
rdar://174185162
Reviewed by Dan Glastonbury.
Accurately serialize the ShaderGraph across IPC to avoid
reconstruction issues in the GPU process.
* Source/WebKit/GPUProcess/graphics/Model/ModelBridge.swift:
* Source/WebKit/GPUProcess/graphics/Model/ModelTypes.h:
* Source/WebKit/GPUProcess/graphics/Model/ModelUtils.swift:
(debugPrintValue(_:indent:)):
(nodeDataTypeString(_:)):
* Source/WebKit/GPUProcess/graphics/Model/USDModel.swift:
(constantValues(_:WKBridgeConstant:)):
(toWKBridgeConstantContainer(_:colorOverride:)):
(toWKBridgeDataType(_:)):
(toWKBridgeDataTypeFromSGRawValue(_:fallback:)):
(toWebNode(_:colorOverride:)):
(texcoordName(for:)):
(textureCoordinate(from:)):
(toWebMaterialGraph(_:)):
(shaderGraphValuesEquivalent(_:_:)):
(shaderGraphNodeDataEquivalent(_:_:)):
(shaderGraphsStructurallyEqual(_:_:)):
(ShaderGraph.fromWKDescriptor(_:)):
(makeConstantSGNode(from:)):
(fromWKBridgeDataType(_:)):
(fromWKBridgeConstant(_:)):
(USDModelLoader.loadModel(from:)):
(toWKBridgeConstantContainer(_:)): Deleted.
(toWebNodes(_:)): Deleted.
(toWebNode(_:)): Deleted.
* Source/WebKit/GPUProcess/graphics/Model/WebKitMesh.mm:
(WebModel::convert):
* Source/WebKit/Shared/Model.serialization.in:
* Source/WebKit/WebProcess/Model/ModelInlineConverters.h:
(WebKit::toVertexFormat):
(WebKit::toPrimitiveTopology):
(WebKit::toIndexType):
(WebKit::toTextureViewDimension):
(WebKit::toTextureFormat):
(WebKit::toTextureUsageFlags):
(WebKit::toCpp):
(WebKit::convert):
Canonical link: https://commits.webkit.org/311732@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications