Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d2d0e337b5fc2697513e1f4933342cd678400dc3
https://github.com/WebKit/WebKit/commit/d2d0e337b5fc2697513e1f4933342cd678400dc3
Author: Sammy Gill <[email protected]>
Date: 2026-04-21 (Tue, 21 Apr 2026)
Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderFlexibleBox.cpp
Log Message:
-----------
[Attempt Two] Zoom.com: Copy Invitation button is difficult to click.
https://bugs.webkit.org/show_bug.cgi?id=210791
rdar://170479667
Reviewed by nobody.
In the in iteration of this fix we applied the new logic, which allowed
percent height descendants to resolve against ancestor flex items
depending on which phase of flex layout we are in, to work in both
standards in quirks mode. However, this ended up causing problems for
documents in standards mode even though the bug we were attempting to
fix was in quirks mode. So in this patch we can just make this fix more
scoped to only target documents in quirks mode.
Originally-landed-as: 310254@main (aeb2eadcea86). rdar://170479667
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::flexItemHasPercentHeightDescendants const):
In some cases, percent height descendants can get registered on the
flexbox rather than the flex item. Before this patch, that meant
skipContainingBlockForPercentHeightCalculation would always return true
for those flex items. However, now we may get a different value for that
flex item depending on which phase of flex layout we are in. Instead, if
the flexbox has percent height descendants registered then we need to
always check if the flex item is the containing block for that
descendant.
Canonical link: https://commits.webkit.org/311739@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
