Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3c85d58466e8b26669d3e73291a297f42f662cca
https://github.com/WebKit/WebKit/commit/3c85d58466e8b26669d3e73291a297f42f662cca
Author: David Quesada <[email protected]>
Date: 2026-04-21 (Tue, 21 Apr 2026)
Changed paths:
M Tools/Scripts/check-for-inappropriate-objc-class-names
Log Message:
-----------
check-for-inappropriate-objc-class-names reports false positives due to
linker-generated helper functions
https://bugs.webkit.org/show_bug.cgi?id=312947
rdar://175271158
Reviewed by Richard Robinson.
When delay-init linking an Objective-C class, the linker can now generate a
helper function
with a name of the format "_OBJC_CLASS_$_TheClassName$loadHelper_x8". This
causes failures
from our check-for-inappropriate-objc-class-names script, which detects that
symbol as an
Objective-C class named "TheClassName$loadHelper_x8".
Prevent this by excluding all symbols from the __TEXT segment when considering
Objective-C
class names, since the metadata for classes (i.e. any content that would ever
legitimately
produce issues) is placed into other sections.
While I was in the area, I also changed the output formatting to print 'error:'
in
lowercase since Xcode knows how to surface such prefixed lines as separate
errors rather
than burying that output in the build transcript.
* Tools/Scripts/check-for-inappropriate-objc-class-names:
Augment the `nm` invocation to print the full mach-o info about the symbols
so that
the segment is included in the output. That then requires updates to the
name
extraction to account for the fact that the line now contains more text
than just the
symbol name.
Canonical link: https://commits.webkit.org/311750@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
