Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cebb536ebef4485f03a053cd129166e657a543f7
https://github.com/WebKit/WebKit/commit/cebb536ebef4485f03a053cd129166e657a543f7
Author: Ahmad Saleem <[email protected]>
Date: 2026-04-22 (Wed, 22 Apr 2026)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/fast/forms/fieldset/fieldset-deprecated-flexbox-expected.html
M Source/WebCore/html/HTMLFieldSetElement.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
Log Message:
-----------
Fieldset with display: -webkit-box should not create a
RenderDeprecatedFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=260074
rdar://114094538
Reviewed by Alan Baradlay.
This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.
When a fieldset has display: -webkit-box, it creates a
RenderDeprecatedFlexibleBox
which causes sizesPreferredLogicalWidthToFitContent() to shrink-wrap children to
zero width. Fix by extending ConstructBlockLevelRendererFor to cover deprecated
flex
types so fieldset forces block flow, matching the existing pattern for inline
and
table display types.
* LayoutTests/TestExpectations: Progression
* LayoutTests/fast/forms/fieldset/fieldset-deprecated-flexbox-expected.html:
Rebaselined
* Source/WebCore/html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::createElementRenderer):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
* Source/WebCore/rendering/RenderElement.h:
Canonical link: https://commits.webkit.org/311784@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications