Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 93299410c2e840be2f37ba7673ce11db3520a741
https://github.com/WebKit/WebKit/commit/93299410c2e840be2f37ba7673ce11db3520a741
Author: Wenson Hsieh <[email protected]>
Date: 2026-04-23 (Thu, 23 Apr 2026)
Changed paths:
A
LayoutTests/fast/text-extraction/debug-text-extraction-hidden-radio-checkbox-expected.txt
A
LayoutTests/fast/text-extraction/debug-text-extraction-hidden-radio-checkbox.html
M Source/WebCore/page/text-extraction/TextExtraction.cpp
M Source/WebCore/page/text-extraction/TextExtractionTypes.h
M Source/WebKit/Shared/TextExtractionToStringConversion.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
Log Message:
-----------
[AutoFill Debugging] Include transparent or offscreen inputs, as long as they
are labeled by visible elements
https://bugs.webkit.org/show_bug.cgi?id=313146
rdar://175372296
Reviewed by Aditya Keerthi.
All offscreen (i.e. does not intersect with the collection rect) or transparent
DOM elements are
currently excluded by default. This change relaxes that policy in the case
where an input or form
control is labeled by an element that is on-screen and non-transparent.
Test: fast/text-extraction/debug-text-extraction-hidden-radio-checkbox.html
*
LayoutTests/fast/text-extraction/debug-text-extraction-hidden-radio-checkbox-expected.txt:
Added.
*
LayoutTests/fast/text-extraction/debug-text-extraction-hidden-radio-checkbox.html:
Added.
Add a new layout test to exercise this scenario.
* Source/WebCore/page/text-extraction/TextExtraction.cpp:
(WebCore::TextExtraction::visibleAssociatedLabelBounds):
(WebCore::TextExtraction::extractItemData):
(WebCore::TextExtraction::extractRecursive):
* Source/WebCore/page/text-extraction/TextExtractionTypes.h:
* Source/WebKit/Shared/TextExtractionToStringConversion.cpp:
(WebKit::shouldIncludeFormControlValue):
Skip the `value` in the case where there is a rendered text child, to avoid
redundancy.
(WebKit::populateJSONForItem):
(WebKit::addPartsForItem):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
Canonical link: https://commits.webkit.org/311890@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
