Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0b4583ef0eec75612faab62a074fb85a6f00b5f7
      
https://github.com/WebKit/WebKit/commit/0b4583ef0eec75612faab62a074fb85a6f00b5f7
  Author: Chris Dumez <[email protected]>
  Date:   2026-04-24 (Fri, 24 Apr 2026)

  Changed paths:
    M Source/WebCore/bindings/scripts/CodeGenerator.pm

  Log Message:
  -----------
  Remove outdated FIXME in CodeGenerator::UpdateFile
https://bugs.webkit.org/show_bug.cgi?id=313210

Reviewed by Alexey Proskuryakov.

The FIXME suggested only writing output files when content changes,
but as discussed in https://bugs.webkit.org/show_bug.cgi?id=131756,
this is not viable: skipping the write leaves the output timestamp
older than the inputs, causing the build system to re-run the
generator on every subsequent build. Touching the timestamp to avoid
that would still trigger downstream recompilation, defeating the
purpose. Drop the misleading FIXME.

* Source/WebCore/bindings/scripts/CodeGenerator.pm:
(UpdateFile):

Canonical link: https://commits.webkit.org/311950@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to